@Valid not applying to elements of unwrapped Iterable

dsw2127 · **Joined:** Wed May 28, 2014 8:56 pm **Posts:** 1

I have a field in a bean annotated as such:

Code:

@UnwrapValidatedValue
@Valid
private Optional<List<MyCustomType>> stuff = Optional.absent();

I would hope that the @Valid would cause each of the instances of MyCustomType in the List to be validated, but as of yet I have not been able to get that to work. The unwrapping works correctly so that the List itself is validated if I apply @NotNull or other such annotations, but the @Valid annotation does not cause the elements of the list to be validated.

My value unwrapper looks like:

Code:

import org.hibernate.validator.spi.valuehandling.ValidatedValueUnwrapper;

import com.fasterxml.classmate.TypeResolver;
import com.google.common.base.Optional;

public class OptionalValueUnwrapper extends ValidatedValueUnwrapper<Optional<?>>
{
   private final TypeResolver typeResolver = new TypeResolver();

   @Override
   public Object handleValidatedValue(Optional<?> value)
   {
      if (!value.isPresent()) {
          return null;
      }
      return value.get();
   }

   @Override
   public Type getValidatedValueType(Type valueType)
   {
           ResolvedType resolvedType = typeResolver.resolve(valueType);
           return resolvedType.typeParametersFor(Optional.class).get(0).getErasedType();
   }
}

I am using hibernate-validator 5.1.1.Final

Any suggestions?

Thank you!

Gunnar · **Joined:** Sat Jan 24, 2009 12:46 pm **Posts:** 388

Hi,

I think you've hit a bug. I've filed https://hibernate.atlassian.net/browse/HV-895 for this.

Maybe you'd like to help out with this and take a look at the possible cause yourself? I'd assume the handling of unwrapping and cascading validation in ValidatorImpl doesn't take the combination of the two into account properly.

--Gunnar