DirtyCheck with Instrumentation - A Bug?

Kai · **Posted:** Thu Jan 05, 2012 8:52 am

Hi!

I am wondering if this code is a bug or can be optimized (Hibernate 3.6.8.Final):

Code:

public final class EntityEntry implements Serializable {
  public boolean requiresDirtyCheck(Object entity) {
    return isModifiableEntity() && (getPersister().hasMutableProperties() || !FieldInterceptionHelper.isInstrumented(entity) || FieldInterceptionHelper.extractFieldInterceptor(entity).isDirty());
  }

If my entity is modifiable and not mutable and instrumentized, then I want to return the result of isDirty().
I would expected something like:

Code:

  public boolean requiresDirtyCheck(Object entity) {
    if (!isModifiableEntity() || !getPersister().hasMutableProperties()) {
      return false;
    }
    if (FieldInterceptionHelper.isInstrumented(entity) && !FieldInterceptionHelper.extractFieldInterceptor(entity).isDirty()) {
      return false;
    }
    return true;
  }

Can someone give me a reason for the original implementation or is it a bug?

Wiemer · **Joined:** Tue Dec 19, 2006 11:05 am **Posts:** 11

Another desirable improvement would be to let the field interceptor register a modified entity in a 'potential dirty' list. For those entities the dirty check does not even need to visit them all...