handle failed saveOrUpdate with rollback

mc1392 · **Joined:** Fri May 16, 2008 3:59 pm **Posts:** 30

All,

I here you cannot rollback after committing. So I plan to use this code to rollback if my updates fail:

Code:

try{
            session = HibernateUtil.getSessionFactory().getCurrentSession();
            session.beginTransaction();
            
            session.saveOrUpdate(fa);
            
            }catch(HibernateException ex){
               ex.printStackTrace();
               log.error(ex.getMessage());
               session.getTransaction().rollback();
               
            }
            // This closes the session.
            // If you call it again, you'll get an exception
            session.getTransaction().commit();
            parsed = true;

         }

Does this look right/well?
Please give your input.

amersohail794 · **Joined:** Wed Sep 21, 2005 8:18 am **Posts:** 31

Well you don't need to explicity mention session.rollback because if transaction is not committed, all operations are rollback automatically on close of session.

Cameron McKenzie · **Posted:** Sat Jun 28, 2008 12:30 pm

The failed commit will trigger a rollback to all of the resources that participated in the transaction. So, to that end, you don't need any extra code to do the rollback.

Is there perhaps some higher purpose you're trying to achieve here, such as reporting the rollback to other resources, reporting or logging mechanisms?

mc1392 · **Joined:** Fri May 16, 2008 3:59 pm **Posts:** 30

I am beginning to realize what I'm trying to achieve is a batch all or none process. So maybe I'm explaining myself incorrectly.

Cameron McKenzie · **Posted:** Fri Jul 04, 2008 10:52 am

If it's a batch process, then use batch processing!