Table:
CREATE TABLE `message` (
`id` int(11) NOT NULL auto_increment,
`folder` int(11) NOT NULL,
`uid` varchar(50) NOT NULL,
`from` varchar(50) NOT NULL,
`to` text NOT NULL,
`content` text,
`dateLastModified` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP,
PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

When use hibernate to save one message into my db (I use MySQL).
it will create a sql script:
insert into message(...,from,...) values (...);
Of course, this sql script is wrong, because of the key word "from".

I found the source code to generate the sql script is:
org.hibernate.sql.Insert.Java:
.............
buf.append("insert into ")
.append(tableName);
if ( columns.size()==0 ) {
buf.append(' ').append( dialect.getNoColumnsInsertString() );
}
else {
buf.append(" (");
Iterator iter = columns.keySet().iterator();
while ( iter.hasNext() ) {
buf.append( iter.next() );
if ( iter.hasNext() ) {
buf.append( ", " );
}
}
buf.append(") values (");
............

to fix the problem,
we could do like this:
insert into message(...,`from`,...) values (...);(in MySQL, I am not sure in other Database, such as MSSQL).

so the code should be like this:

buf.append("insert into ")
.append(tableName);
if ( columns.size()==0 ) {
buf.append(' ').append( dialect.getNoColumnsInsertString() );
}
else {
buf.append(" (");
Iterator iter = columns.keySet().iterator();
while ( iter.hasNext() ) {
buf.append("`");//Bill Add, to avoid key word for sql script
buf.append( iter.next() );
buf.append("`");//Bill Add
if ( iter.hasNext() ) {
buf.append( ", " );
}
}
buf.append(") values (");

Thus, It works!!!

I think this is a small bug of hibernate, am I right?

How Can I report to Hibernate org?

thx for reading!!!

could use

/**
* The character specific to this dialect used to begin a quoted identifier.
*
* @return The dialect's specific open quote character.
*/
public char openQuote() {
return '"';
}

/**
* The character specific to this dialect used to close a quoted identifier.
*
* @return The dialect's specific close quote character.
*/
public char closeQuote() {
return '"';
}

in Dialect (sub) class.

Hibernate will have to stay database neutral, so probably this is not a good enough solution. However, you can modify your mappings and put those quotes around column names. In case of SqlServer hibernate generated the right sql for me when I put column names in brackets which is sql server's keyword delimiter.


Farzad-

so it should be change to:

buf.append(dialect.openQuote());//Bill Add, to avoid key word for sql script
buf.append( iter.next() );
buf.append(dialect.closeQuote());//Bill Add

Farzad, you are right.

however, it seams using Dialect openQuote and closeQuote is better.

and I check SQL server dialect, they are
....


......

and mysql dialect



...

right?

You have a point there. I digged into HB code and it appears that those values are used if a column is quoted with quotes. This is the code from HB code:





Give it a try and see if it appears properly on insert commands. You still need to change mappings though.


Farzad-

thx Farzad.

I have check that quote method is used at org.hibernate.sql.Template renderOrderByStringTemplate and renderWhereStringTemplate,
the codes are:

and


it seams no problem, (because it has "*.*", it will not have problem.).

The reason why I want to change the Insert class is that:
usually, the user just care about the column name, doesn't care about the name is keyword or not (I think). If the the name is key word, as you suggested, it should change the mapping name (add the quote). it doesn't like what we usually do.
so, for more easier to use, I suggest to change the Insert Class.



improve HB, right?
^-^

Sure thing. The only thing I am not sure is that what that column name collection contains. There is a chance that the collection holds the right column name if it is quoted properly in mappings. If so, the solution you are suggesting will add extra quotes to an already quoted column name.



Farzad-

I C,
We could do like quote method in Dialect.


Test it whether contains quote first.
so:


Ok？

Naha, I did a small test and hibernate does change quoted columns while inserting. So here is my entity xml file:



and here is the insert sql hibernate generated:



You can see hibernate has actually converted my quotes to sql server quotes, which is the database/dialect I used for testing. In this case there is no need for modifying hibernate code.


Farzad-

oh I C.
How about the key world "from" or "order" or else?

oh I C.
How about the key word "from" or "order" or else?

i C
Farzad， your method is better, thx