Ordering Results in createCriteria

clueo8 · **Joined:** Mon Dec 10, 2007 8:18 am **Posts:** 5

I've been looking for days on how to order my results. I think I have narrowed it down that I have to do this on the session level.

Here is my line of code:

Code:

HibernateUtils.getSession().createCriteria(EventLocator.class).addOrder( Order.asc("event_date") ).list();

It doesn't seem to be ordering by the event_date as I would like.

The previous code was just:

Code:

HibernateUtils.getSession().createCriteria(EventLocator.class).list();

I had to import the org.hibernate.criterion.Order class to get it to compile. But my results don't come back ordered at all. Any info would help!
Thank you.

gonzao_diaz · **Joined:** Mon Nov 26, 2007 2:29 pm **Posts:** 443

Is event_date a real date type, or it's String representation?

clueo8 · **Joined:** Mon Dec 10, 2007 8:18 am **Posts:** 5

gonzao_diaz wrote:

Is event_date a real date type, or it's String representation?

event_date is the actual name of the column in the database.

eventDate is it's String representation.

gonzao_diaz · **Joined:** Mon Nov 26, 2007 2:29 pm **Posts:** 443

Do you have a property returning the exact event_date, as a date?
A criteria query has to order by that, not by your string representation.
Unless you have already a getter called "getEvent_date" (I doubt it), the sorting is meaningless.
In general, HQL deals with properties, not fields.

clueo8 · **Joined:** Mon Dec 10, 2007 8:18 am **Posts:** 5

gonzao_diaz wrote:

Do you have a property returning the exact event_date, as a date?
A criteria query has to order by that, not by your string representation.
Unless you have already a getter called "getEvent_date" (I doubt it), the sorting is meaningless.
In general, HQL deals with properties, not fields.

In my mapping file, I have:

Code:

<property name="eventDate" column="event_date" type="java.lang.String" not-null="true"/>

In my class file, I have:

Code:

private String m_eventDate = "";

public String getEventDate() {
   return m_eventDate;
}
public void setEventDate(String p_date) {
   m_eventDate = p_date;
}

So I think I got it working with this:

Code:

HibernateUtils.getSession().createCriteria(EventLocator.class).addOrder( Order.asc("eventDate") ).list();

Thank you so much for your help!

gonzao_diaz · **Joined:** Mon Nov 26, 2007 2:29 pm **Posts:** 443

no, you didn't.
If your column is date, it should be mapping to date.
If you want to have a nicely formatted date for your user interface, you can create a getter that returns a String, maybe using a SimpleDateFormat r something alike, but the ordering must be done through the real date, mapped as a date.

If the ordering seems to work now, is just because whatever transformation is being done from date to string (maybe in your local date format) produces a sorting "by string representation" that is similar to the sorting by real date.
But sorting by string representation is useless and dangerous, you should sort by date.

clueo8 · **Joined:** Mon Dec 10, 2007 8:18 am **Posts:** 5

gonzao_diaz wrote:

no, you didn't...

I don't really have the column in the database declared as date, its just a varchar (It is like this for a few reasons). I have the struts validation making it a strict date format, so sorting by string still works. Ex: 01-01-2008 is before 01-02-2008.

VampBoy · **Posted:** Thu Jan 17, 2008 12:57 pm

Based on your String value 03-01-2007 would sort before 04-01-2006.