Hiberante validator fails when using collection classes

mpermar · **Joined:** Mon Nov 29, 2004 8:15 am **Posts:** 8

Hi there,

It seems that Hibernate validator framework fails to validate collections when you use concrete collection classes instead of interfaces.

So, for example, if you modify the org.hibernate.validator.test.collections.Tv class to have this:

Code:

@Valid
public ArrayList<Presenter> presenters = new ArrayList<Presenter>();

instead of this:

Code:

@Valid
public List<Presenter> presenters = new ArrayList<Presenter>();

the unit test will fail.

Cheers,
Martin

emmanuel · **Posted:** Tue Sep 11, 2007 4:56 pm

That is correct.
I am not too fussed about it, since it's a bad practice anyway but if you provide a patch to fix that, I'll apply it.

mpermar · **Joined:** Mon Nov 29, 2004 8:15 am **Posts:** 8

Yes, however the following change also makes the test fail:

Code:

@Valid
private ArrayList<Presenter> presenters = new ArrayList<Presenter>();

public List<Presenter> getPresenters() {
      
   return presenters;
}

Anyways, I didn't post th entry to debate about good or bad pratices but to highlight this issue just in case it hadn't been detected and had important consequences. I haven't tested other collections though. Whatever you do with this will be your choice.