Hibernate version:3.2.0

Hi. If you have a property named "scoreA" (camel-case), I think it should be transformed to "score_a", but ImprovedNamingStrategy outputs "scorea".

I've been playing with the ImprovedNamingStrategy a bit, and you can twist this (bug?) a bit more: I'd say that "scoreAB" should be "score_a_b", but instead you get "scoreab"

I've browsed the source code, and it looks like it detects a "word-change" by checking the case of the previous and next letters of the current one. This assumes words have more than one letter, and that need not be the case (like in "scoreA").

My suggestion would be to change the logic so a word-change is marked by a capital letter, regardless of its neighbours; the first letter could be a exception, as some people do not make the first letter lower-case. The change is really simple, I could submit it if requested (I've done it anyway for our project).

Thanks,

Carlos

as long as it does not convert scoreURL into score_U_R_L

..but not sure if fixing this now oold strategy will be a good thing since it might break existing apps.

Mmm... yes, my suggestion does "score_U_R_L" and it would break many
apps. I guess the problem is that some coding standards mandate that
acronyms are treated like words, other don't. The one we're using
makes you write scoreUrl, not scoreURL. Nevertheless, I think in this
respect it's quite common to be inconsistent. In fact, even the JDK is
not consistent (you have MimePart and XMLFilterImpl). Out of
curiosity, I've made a quick browse of Hibernate's API, and the same
thing happens: there is HqlSqlBaseWalker but also ANSICaseFragment.

I take back my suggestion, then. On the other hand, regardless of
whether you use MIME or Mime, I'd say the problem with one letter
words is still the same, and that "scoreA" should be "score_a", don't
you think? But I'd understand that you prefered to stick to "scorea"
on behalf of backwards compatibility.

Thanks anyway,

Carlos

i agree scoreA should become scora_a; but that does not prevent scoreURL to become score_url - you just need an additional check.