WasCommitted value remains false after transaction.Commit()

avissar · **Posted:** Wed Jan 31, 2007 6:01 am

I'm working with NHibernate 1.2 beta3, against an Oracle database and stumbled with what seems to be a bug with the WasCommitted flag (occurs in both ADO.NET providers).

This code will demonstrate the problem:

Code:

            transaction = session.BeginTransaction();
            transaction.Commit();
            Console.WriteLine(session.Transaction.WasCommitted.ToString());
            Console.WriteLine(transaction.WasCommitted.ToString());

Executing this code will print 'False' for the session.Transaction.WasCommitted and a desired 'True' for the transaction.WasCommitted.

This does not accure in NHibernate 1.0.3 version.

gert · **Joined:** Thu Jan 19, 2006 4:29 pm **Posts:** 348

avissar wrote:

Executing this code will print 'False' for the session.Transaction.WasCommitted and a desired 'True' for the transaction.WasCommitted.

What if

Code:

if (session.Transaction != transaction)
  Console.WriteLine("new transaction started");

From ConnectionManager

Code:

      public ITransaction Transaction
      {
         get
         {
            if (transaction == null)
            {
               transaction = session.Factory.TransactionFactory.CreateTransaction(session);
            }
            return transaction;
         }
      }

Gert

avissar · **Posted:** Wed Jan 31, 2007 6:58 am

gert wrote:

What if

Code:

if (session.Transaction != transaction)
  Console.WriteLine("new transaction started");

session.Transaction != transaction does evaluates true.
But even though a new transaction object is created, I don't think a new database transaction is opened.

This code results with exactly the same output:

Code:

transaction = session.BeginTransaction();
session.Transaction.Commit();
Console.WriteLine(session.Transaction.WasCommitted.ToString());
Console.WriteLine(transaction.WasCommitted.ToString());

But in any case this is odd behaviour, isn't it?

sergey · **Posted:** Wed Jan 31, 2007 7:04 am

I implemented it to match Hibernate3 behavior, and yes, this may be confusing. session.Transaction is the current transaction of the session. After a transaction is completed it is no longer considered current for the session, and the session creates a new ITransaction object. The new transaction is not started immediately though.

samueljob · **Joined:** Mon Jan 08, 2007 11:59 pm **Posts:** 31

I am confused with the usage of Session.Transaction.WasCommitted

When is this call useful, because as I see it, it will always return false.

Job Samuel

sergey · **Posted:** Wed Jan 31, 2007 7:58 am

This will always return false, yes. But you can remember the original transaction somewhere and then originalTransaction.WasCommitted will return true or false depending on whether the transaction committed successfully.