how to fetсh a Table by TableIdentifier?

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

Hi there!

I intend to write custom reverse engineering strategy class extending

Code:

org.hibernate.cfg.reveng.DefaultReverseEngineeringStrategy

My question is: how do I get a correct

Code:

org.hibernate.mapping.Table

object by

Code:

org.hibernate.cfg.reveng.TableIdentifier

inside the method

Code:

 org.hibernate.cfg.reveng.DefaultReverseEngineeringStrategy.isForeignKeyCollectionInverse(...)

?

Thanks!

max · **Posted:** Thu Dec 28, 2006 3:06 pm

What do you need it for ?

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

just wanted to fix many-to-many annotation generating

max · **Posted:** Sun Dec 31, 2006 8:14 am

but what do you need the Table object for ? what info are you missing ?

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

Well, If I had a Table instance, I could pass it to method isManyToManyTable(Table) to determine whether it's a many-to-many join table

max · **Posted:** Tue Jan 02, 2007 6:20 am

fair enough - put it in jira with a link to this posting.

...but what would you use in addition to decide which side get's to be inverse and which side should not ?

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

max wrote:

fair enough - put it in jira with a link to this posting.

done! http://opensource.atlassian.com/project ... se/HBX-846

max wrote:

...but what would you use in addition to decide which side get's to be inverse and which side should not ?

well, for two-columns join tables there is a simple solution.

Code:

boolean isForeignKeyCollectionInverse(String name, TableIdentifier fkTable, List columns, TableIdentifier fkRefTable, List refColumns))
{
      Table table = getTableByTableId(fkTable); // this needs to be implemented
      if(isManyToManyTable(table))
      {
         if (table.getColumn(0).getName().equals(name)) {
            return true;
         }         
         if (table.getColumn(1).getName().equals(name)) {
            return false;
         }         
      }
      return true;
  
}

max · **Posted:** Tue Jan 02, 2007 6:43 am

For now you can look the table up through the Configuration object.

But in the next release i'll might consider changing the api to be an Table instead of TableIdentifier since at the time the method is called we should have the complete table...but need to check that.

Put in jira so we don't forget it - thanks.

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

max wrote:

For now you can look the table up through the Configuration object.

But in the next release i'll might consider changing the api to be an Table instead of TableIdentifier since at the time the method is called we should have the complete table...but need to check that.

Put in jira so we don't forget it - thanks.

Jira task created.

Can you point me to how do I obtain a Configuration object from within DefaultReverseEngineeringStrategy methods?

Thanks!

max · **Posted:** Tue Jan 02, 2007 6:54 am

sorry I spoke too fast; you can't do that because it is what the reverse engineering strategy is used to built thus it is not correct until later on.

But we could probably consider giving access to a partial/other api to access the (until now) found tables etc.

Sonar · **Joined:** Wed Dec 27, 2006 10:03 am **Posts:** 19

Hi Max,

The task I've created is still unassigned for some reason. Can you please assign it to a proper person? Thanks!

Alex

max · **Posted:** Mon Jan 08, 2007 4:57 am

i've assigned it to a release.

joy4all · **Joined:** Tue Jan 30, 2007 1:35 pm **Posts:** 27

Hi all,

I facing the same problem. May I know how can I get the table object ?

This is because I need to get the first column of the table. I found out the tableobj.getColumns can do that. Any other API I can call to get this info ?

Thanks in advance. :)

IGx89 · **Joined:** Fri Jul 28, 2006 10:53 am **Posts:** 15

Any updates on this? The bug still hasn't been fixed, and even more annoyingly the method isForeignKeyCollectionInverse is still just always returning true. That makes the reverse engineering of many-to-many relationships useless unless the mapping XML/annotations are manually edited afterwards (not really an option for us).

It would seem relatively simple to fix to! Why the delay? If I submitted a patch for it, would you put it in?

max · **Posted:** Wed Sep 12, 2007 9:41 am

patches always increases the chances of inclusion - so feel free ;)

With respect to it being "trivial" then it is not completely trivial since this method can be called before all tables have been collected (as far as I *remember*)