Hi everyone,

I have a problem with bulk update.
All the POJOs that we use have one superclass BasicObject, now we want to update just rows in the corresponding table BASIC_OBJECT. We use a table per subclass strategy.

I had a look in the Hibernate source and found out that in QueryTranslatorImpl.builAppropriateStatementExecutor() line 430
if (persister.isMultiTable())
is the bad boy, because if I change in the persister Implementation (JoinedSubclassEntityPersister) the return value from true to false
everything is working.
And if I understand the Comments in QueryTranslatorImpl line 431-433 correct maybe there will be a workaround?
Ok in line 434 I could change
return new MultiTableUpdateExecutor( walker );
to
return new BasicExecutor( walker, persister );
but I think this is not the best practice and have some other implications that I do not know.
So is this behavior correct or is there a bug in JoinedSubclassEntityPersister / MultiTableUpdateExecutor?

thanks in advance
Roland

Hibernate version:
hibernate-3.1beta2, hibernate-annotations-3.1beta4 latest from HEAD
Mapping documents:
Using annotations
Code between sessionFactory.openSession() and session.close():

HQL:
String hql = "update from BasicObject bo set bo.lockedBy = :lockedBy, bo.lockTime = :lockTime where bo.objectID = :objectID and ((bo.lockedBy = :lockedBy) or (bo.lockTime < :now) or (bo.lockTime is null))"
query = s.createQuery(hql);
query.setString("lockedBy", db.getCurrentUser().getUsername());
query.setTimestamp("now", now);
query.setLong("objectID", objectID);
rows = query.executeUpdate();

Full stack trace of any exception that occurs:
org.hibernate.HibernateException: no table name defined for insert-select
at org.hibernate.sql.InsertSelect.toStatementString(InsertSelect.java:56)
at org.hibernate.hql.ast.exec.AbstractStatementExecutor.generateIdInsertSelect(AbstractStatementExecutor.java:79)
at org.hibernate.hql.ast.exec.MultiTableUpdateExecutor.<init>(MultiTableUpdateExecutor.java:47)
at org.hibernate.hql.ast.QueryTranslatorImpl.buildAppropriateStatementExecutor(QueryTranslatorImpl.java:434)
at org.hibernate.hql.ast.QueryTranslatorImpl.doCompile(QueryTranslatorImpl.java:170)
at org.hibernate.hql.ast.QueryTranslatorImpl.compile(QueryTranslatorImpl.java:101)
at org.hibernate.impl.SessionFactoryImpl.getQuery(SessionFactoryImpl.java:468)
at org.hibernate.impl.SessionImpl.getQueries(SessionImpl.java:1025)
at org.hibernate.impl.SessionImpl.executeUpdate(SessionImpl.java:1006)
at org.hibernate.impl.QueryImpl.executeUpdate(QueryImpl.java:89)
at de.mtg.vorges.database.impl.DBServicesImpl.lock(DBServicesImpl.java:57)
at de.mtg.vorges.common.SystemHelper.lock(SystemHelper.java:150)
at de.mtg.vorges.client.dialog.component.CommonTreeCtrl.handleEdit(CommonTreeCtrl.java:208)
at de.mtg.vorges.client.dialog.component.CommonTreeDlg.actionPerformed(CommonTreeDlg.java:276)
at de.mtg.independent.util.RedirectAction.actionPerformed(RedirectAction.java:85)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1849)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2169)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:420)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:258)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:234)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:231)
at java.awt.Component.processMouseEvent(Component.java:5488)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3093)
at java.awt.Component.processEvent(Component.java:5253)
at java.awt.Container.processEvent(Container.java:1966)
at java.awt.Component.dispatchEventImpl(Component.java:3955)
at java.awt.Container.dispatchEventImpl(Container.java:2024)
at java.awt.Component.dispatchEvent(Component.java:3803)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4212)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3892)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3822)
at java.awt.Container.dispatchEventImpl(Container.java:2010)
at java.awt.Window.dispatchEventImpl(Window.java:1766)
at java.awt.Component.dispatchEvent(Component.java:3803)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:463)
at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:234)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:163)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:157)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:149)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:110)
Name and version of the database you are using:
MS-SQL 2005 Preview

actually it sounds more like an issue in either the dialect or the binding (metadata parsing) code.

the only way what you see should occur is when the binding code does not generate a temporary id-storage table name for the entity.

So it sounds like you are using the annotation-based Configuration; correct?

Also, which dialect do you use?

Hello steve,

the mappings are done with Annotations, but the configuration is done through a hibernate.cfg.xml file, hope that answers your question.

The dialect is org.hibernate.dialect.SQLServerDialect.

Hope my first post makes it clear, that our Inheritance structure is rooted on this BasicObject so all other classes are derived from this one.

thx Roland

you use SQLServerDialect to connect to a MySQL database?

yes, you use joined-subclass, i understand.

it is the mappings I am talking about. I.e. you use AnnotationConfiguration as opposed to the normal Configuration...

No, at the end of my first posting there is name and version of DB ->MS SQL 2005 Preview

Of course we use AnnotationConfiguration.


I forgot to say, with hibernate 3.0.5 and annotations3.0beta1 (ejb3.0 early draft) it worked perfect and we changed @InheritanceJoinColumn -> @PrimaryKeyJoinColumn to get the latest version of hibernate+annotations running.

Roland

Did anything come of this? I'm using SQL Server 2000 and Hibernate 3.1 beta3, and when I try to delete from a joined-subclass, I get the same exception. It seems to work fine on PostgreSQL 8. I'm guessing it's some problem with the dialect, but I wouldn't have any idea what to look at.

Can someone give some insight into this? Is it something missing from the dialect?

I´m having the same problem.
My structure is one superclass and a lot of subclasees extending from that one and when i try to update a field in the subclass table i get the exception: