or

I usually use the first style in NHibernate tests, the second is also certainly possible. ITransaction.Dispose actually doesn't call Rollback explicitly, but since it calls Dispose on the ADO.NET IDbTransaction it wraps, the transaction should be rolled back anyway.

Do you mean in THE NHibernate test or in tests of my app that use NHIbernate?

Is the fisrt style going to work in a production environment?

I am just curious. Thanks for the input. Is the a Best Practice area?

dru

I meant the unit tests that are part of NHibernate source, used to test NHibernate itself. Yes, the first style should work in a production environment (or at least I can't see any reason why it should not work, and I never heard that it didn't). As for Best Practice area, I don't know of any, and don't see many posts related to best practices, but we can of course create a forum for them if people want it.

Is it best practice to dispose of a transaction after you are done with it? I haven't seen that mentioned anywhere.

I would because otherwise you are going to have a transaction waiting for the session to close. So if you are done with the transaction, but not the session i think that it would indeed be a best practice to dispose of the transaction.

Actually, Commit and Rollback call Dispose in the current implementation.

Great. Thanks Sergey. thats what I thought should happen. So there is no need to call dispose explicitly.