Recursing @Valid with @Embeddable

patrick_ibg · **Joined:** Sat Sep 17, 2005 10:41 am **Posts:** 49

Doesn't seem to work. Sample scenario:

Code:

@Embeddable (access=AccessType.FIELD)
public class Contact
{
@NotNull
private String name ;
@NotNull
private String phone ;
...
}

@Entity (access=AccessType.FIELD)
{
@NotNull
private String city ;
@NotNull
private String state ;
...
}

@Entity (access=AccessType.FIELD)
public class Site
{
@NotNull
private String siteName ;

// validation recurses
@Valid
private Address address ;

// validation does not recurse
@Valid
private Contact contact ;
}

When validating "Site", the validator seems to ignore the @NotNull annotations on "Contact".

FWIW, I'm using SEAM, which is calling the hibernate validator for me.

emmanuel · **Posted:** Wed Nov 02, 2005 6:37 am

OK, this is a bug, open it to JIRA saying,
use instance instead of class to avoid circular references in validator

patrick_ibg · **Joined:** Sat Sep 17, 2005 10:41 am **Posts:** 49

Done.

http://opensource2.atlassian.com/projec ... se/ANN-137

emmanuel · **Posted:** Thu Nov 17, 2005 1:35 pm

I cannot reproduce with your sample. I've got the right invalidvalues returned

patrick_ibg · **Joined:** Sat Sep 17, 2005 10:41 am **Posts:** 49

hrm...

maybe specific to the version that i'm using... let me confirm.

patrick_ibg · **Joined:** Sat Sep 17, 2005 10:41 am **Posts:** 49

Got this to work. Stupid error on my part, the @NotNull field was actually being set to an empty String and the error wasn't caught on unit tests.

Sorry for the noise.

For those who care, it's probably good practice to always use @Length (min = 1) for varchar columns, especially if the column has a UNIQUE constraint.

Code:

// required column
@NotNull
@Length (min = 1, max = 100)
@Column (nullable = false, unique = true)
private String serialNumber ;

// non - required column
@Length (min = 1, max = 100)
@Column (nullable = true, unique = true)
private String licenseNumber ;