MySQLDialect.getTableComment() Bug

Emtea · **Joined:** Wed Aug 17, 2005 6:08 pm **Posts:** 2

I'm new to Hibernate and this board but I'm pretty sure I found a bug that hasn't been reported (at least I couldn't find it).

Problem: Creating table with MySQLDialect fails when the table includes comments (<comment>...)

Found: Trying to run the "eg" example that comes with Hibernate 3.0.: "ant eg"

OS: Win2000
Hibernate: 3.0.5
MySQL: Ver 12.22 Distrib 4.0.18, for Win95/Win98 (i32)
Java: 1.5

Solution: The problem occurs because of the SQL syntax MySQLDialect returns for the method getTableComment(). It currently returns the string:

public String getTableComment(String comment) {
return " comment '" + comment + "'";
}

According to MySQL syntax, it should return the string:

public String getTableComment(String comment) {
return " comment = '" + comment + "'";
}

Changing this and recompiling the source allowed the example "ant eg" to work.

gavin · **Posted:** Wed Aug 17, 2005 6:30 pm

This has been reported several times.

Actually it works with latest MySQL releases.

It also works in 3.1 beta releases.

sven · **Posted:** Wed Aug 17, 2005 6:38 pm

For a column it is:

Code:

COMMENT 'string'

For a table it is:

Code:

COMMENT = 'string'

See:
http://dev.mysql.com/doc/mysql/en/create-table.html

Gavin, I believe you when stating that it works with the latest version of MySQL, but I cannot find any hints about that in their documentation. Though I haven't tested it myself.

Best regards
Sven

sven · **Posted:** Wed Aug 17, 2005 6:41 pm

Well, I think I misunderstood you.

I just had a look at MySQLDialect.java:

Code:

public String getTableComment(String comment) {
   return " comment='" + comment + "'";
}

public String getColumnComment(String comment) {
   return " comment '" + comment + "'";
}

It is corrected with regard to the MySQL docs in HB 3.1 beta and will work very well. :)

Sven

Emtea · **Joined:** Wed Aug 17, 2005 6:08 pm **Posts:** 2

Cool, just trying to help. I searched on MySQLDialect and getTableComment on the forum and Google before posting but found nothing. Thought it might be a windows/mysql specific problem that didn't show up for most people.