CGLIBLazyInitializer does not proxy package private methods

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

I have an object that contains a collection mapping (set, one-to-many).
This object itself is cached and referenced by others in a many-to-one.

It all works when the object is not in the cache. If it is in the cache, the many-to-one only contains a Proxy (CGLIBLazyInitializer ), which is all well. unfortunatelly the proxy does not seem to take care of the the mentioned collection, which has package private setter/getter.

I assume this is a bug, because hibernate itself does support private setter/getters.

baliukas · **Posted:** Wed Apr 06, 2005 5:57 am

Change this method to public for test, package methods must be intercepted in the same way as public methods (proxy is defined in the same package as domain class).

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

I already changed it to public and it works now. So this is indeed a bug.

baliukas · **Posted:** Wed Apr 06, 2005 7:18 am

probably it is a bug in some cglib version, I just changed all methods to package in "ProxyTest" (I use Hibernate3 head for this test). It fails on "get/set ID", but it is a different problem.
Try to upgrage cglib, "CGLIBProxy" implementation doe's not filter methods by access modifiers.

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

I currently use Hibernate 3 final, which means cglib 2.1.
That is the last version to my knowledge

baliukas · **Posted:** Wed Apr 06, 2005 10:40 am

Submit test case to jira, probably I am trieng to reproduce it in a wrong way. (I see proxy intercepts package methods in this version)

baliukas · **Posted:** Wed Apr 06, 2005 10:57 am

It can be related to this code in ReflectHelper, private id doe's not work for this reason too :

Code:

public static Method getMethod(Class clazz, Method method) {
      try {
         return clazz.getMethod( method.getName(), method.getParameterTypes() );
      }
      catch (Exception e) {
         return null;
      }
   }

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

Dumb Question, is this the jira of Hibernate or where can I find it?

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

BTW, I use Java5, can that be the reason?

max · **Posted:** Tue Apr 12, 2005 6:13 am

baliukas wrote:

It can be related to this code in ReflectHelper, private id doe's not work for this reason too :

Code:

public static Method getMethod(Class clazz, Method method) {
      try {
         return clazz.getMethod( method.getName(), method.getParameterTypes() );
      }
      catch (Exception e) {
         return null;
      }
   }

is this something we need to react/fix ? what should it do instead ?

baliukas · **Posted:** Tue Apr 12, 2005 7:15 am

"clazz.getMethod" return public methods only, I see this problem exists with id, but I can not reproduce any problem with attribute getter/setter

baliukas · **Posted:** Tue Apr 12, 2005 7:28 am

I modified "DataPoint" class to test it, probably it is too trivial to reproduce this problem. Submit some class with problem to jira, it must be something trivial.

mkopp · **Joined:** Mon Nov 08, 2004 11:58 am **Posts:** 29

brings me again to the question, which jira? the cglib sourceforge page only refers to the sourceforge tracker? Do you mean hiberantes jira?

max · **Posted:** Tue Apr 12, 2005 8:15 am

its hibernates jira http://www.hibernate.org/217.html