Exception handling idiom

mdond · **Joined:** Thu Sep 23, 2004 8:34 am **Posts:** 2

Hibernate version: 2.1

The hibernate documentation proposes following Exception handling idiom:

----------------------------

Session sess = factory.openSession();
Transaction tx = null;
try {
tx = sess.beginTransaction();
// do some work
...
tx.commit();
}
catch (Exception e) {
if (tx!=null) tx.rollback();
throw e;
}
finally {
sess.close();
}

-----------------------------

However this isn't possible, cause tx.rollback() throws a checked HibernateException, so I have to catch the HibernateException in the catch-clause too.

Is this a mistake of the documentation?
It would be nice, to throw only an unchecked Exception from rollback().

Greetings,
Maarten Donders

sivajag · **Joined:** Mon Sep 20, 2004 10:27 am **Posts:** 7

Hi Maarten:

Code:

Session sess = factory.openSession();
Transaction tx = null;
try {
       tx = sess.beginTransaction();
       // do some work
       ...
       tx.commit();
}
catch (Exception e) {
      if (tx!=null) {
           try{
               tx.rollback();
           }
           catch(Exception e){
                 log.warn("Exception Occured when rolling back" ,e);
           }
}
finally {
          sess.close();
} 

It could be done this way too. I think it really depends on how you wanted your layer to behave.

What I feel about the documentation is , it is meant to give you an idea how to implement.

Anyways Hibernate guys correct me if I am wrong

mdond · **Joined:** Thu Sep 23, 2004 8:34 am **Posts:** 2

Hi Siva,

I just noticed in the samples that it seems to be common to let every method which uses hibernate throw a HibernateException. Therefore it isn't necessary to catch the HibernateException in the catch-clause.

I don't like that style, cluttering all my methods with HibernateExceptions, but I'll find my way around that.

Thank you for answering,
Maarten