Hi max (and other hbm2java maintainers).

Got the new release (2.1) and started looking at the JavaDocs to see about some things and... well the package I downloaded has JavaDocs but I don't see any comments that end up in the docs. I shouldn't say any, but maybe there's 3% coverage.

So, (1) did I download the right package? (2) if so, is there a plan to comment the methods and a timeline for that too? (3) where are the other reference docs for hbm2java?

Finally, are there examples of setting up a custom Velocity template and rendering using that template?

Read the Hibernate reference documentation.

please note that velocity templatese are not as powerfull as java based renderer - but for "non java" code generation it can be very useful ,)

It is not a substitute when I want to subclass the BasicRenderer and configure hbm2java to use my renderer.

I gotta say, if Hibernate has a weakness it is the low quality of the JavaDocs. It has, by far, the worst JavaDocs of any project I've ever encountered. This goes for the Tools too, unfortunately. I'm grateful for Hibernate. Glad it exists. Glad to be using it. If I could only choose one thing to improve, however, the top of the list would probably be the JavaDocs.

Thanks for reading my 2cents.

More to the point for my particular case: any pointers for setting up a custom renderer by subclassing BasicRenderer, overriding a few methods and then configuring hbm2java to use my renderer class? The gist of the question is: how do I configure hbm2java to use a custom renderer class (not the default nor Velocity one, but one of my own)?

Thanks.

What part of section 19.2.1 "The config file (optional)" did you not read at http://www.hibernate.org/hib_docs/refer ... ml_single/ ? ;)

Thanks for being a wiseass.

The part that details which methods to override and what order they are called in. The basics. The stuff that should be in javadocs if the coders weren't so sloppy. I mean object==object. Pure slop.

Provide a patch.

Thank you. One concern: I provided a patch to broken .jar loading functionality over 2 months ago. I've seen no activity on it at all. http://opensource.atlassian.com/project ... wse/HB-687 That type of feedback doesn't really encourage participation. Did I not follow correct patch submission procedures in the past?

And, of course, in this case that's something of a catch-22 don't you think?

I don't know what a "catch 22" is, sorry.

The issue you submitted is still open and there is no comment, so there simply wasn't time to review and/or apply it.

From the book by Joseph Heller Catch-22 "...a mysterious regulation that is in essence a circular argument."

In this case if I knew how hbm2java was implemented I could then write the JavaDocs. But of course then I wouldn't need the JavaDocs. So to write the JavaDocs I need to know the information that is supposed to be in the JavaDocs. Its circular. Catch-22.

Read the source code.

Sorry, my bad, I suppose, I should have rejected this issue a while ago. There is no need for the extra addJar() method.

No, there is. The current one is broken. It closes the ZipInputStream after reading one element (one contained file). So one can't use the jar method inside a container. I've been using the patch for 2 months and it fixes a real bug.