I want to store a String property (name) in an sql TEXT column.
I first tried this:

The column was indeed a TEXT column, but when 'name' was fetched from the database it always had length 2048 (it had '\0' characters appended to it).
Then it tried it with sql-type:

which did what I expected.
So what is the exact meaning and purpose of type="text"?

BTW, I'm using MySql.

Ivo

It does the same on MS SQL Server and Oracle 9i.

According to what I can see, Hibernate treats the TEXT types as CLOBS. Unfortunately, JDBC drivers seems to always return a fixed amount of bytes, padded with \0. But the TextType implementation doesn't check for this end-of-string marker...

Just wondering if it is on purpose or if Gavin thought the drivers would behave differently ?

Ummmmm ... its certainly not intended ...

Which drivers did you try?


Have a look at what needs to be changed in TextType and submit a patch to JIRA.

I used MySQL Connector/J 3.0.7 Stable (MM.MySQL)

Mysql: MySQL 3.0.9 stable
MSQLServer: JConnect 3.30
Oracle: ojdbc14.jar



Changes are quite straightforward - you were just adding your byte buffer into the string without taking into account the amount of data you read ;-)

I have corrected this code and it works pretty well. I'll submit the thing to Jira as you propose.

When reading the TextType code, I notice that you were using deprecated java.io classes (deprecated since JDK 1.1) - ie. StringBufferInputStream and others.
In fact, we should now be using java.io.Reader's to properly convert from bytes to char...
Doing so will result in Hibernate not working on JDK 1.0 - is it a problem ?

Nah, Hibernate already needs patching to run on pre-1.2 vms.

Ok, perfect then.

Another question - below is part of the code for the set method:


Problem is the StringBufferInputStream is deprecated as well.

Just wondering why you had to go via a Stream instead of setting the string directly as follows:


Are there any reason to do so ?

Some JDBC drivers (Oracle, in particular) behave better when passed streams than when passed very long strings or byte arrays. Sounds crazy, I know.

Patch submitted to JIRA (HB-486)

Just wondering if using the mapping:


is a better approach to use CLOB than the one described at http://www.hibernate.org/76.html (Mapping a Clob to a String)

?