-->
These old forums are deprecated now and set to read-only. We are waiting for you on our new forums!
More modern, Discourse-based and with GitHub/Google/Twitter authentication built-in.

All times are UTC - 5 hours [ DST ]



Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 
Author Message
 Post subject: Any plans for commons-lang 2?
PostPosted: Tue Oct 14, 2003 6:29 am 
Regular
Regular

Joined: Thu Aug 28, 2003 10:54 am
Posts: 67
Are there any plans to migrate hibernate to commons-lang 2.0?

just wondering...


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 6:45 am 
Hibernate Team
Hibernate Team

Joined: Tue Aug 26, 2003 6:10 am
Posts: 8615
Location: Neuchatel, Switzerland (Danish)
....one -1 for commons-lang 2, is that is grown considrable in size - and we ain't using more than 1% of its functionallity......

_________________
Max
Don't forget to rate


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 6:49 am 
Hibernate Team
Hibernate Team

Joined: Tue Aug 26, 2003 7:19 pm
Posts: 2364
Location: Brisbane, Australia
I am not totally sure what we are using but I would like to see use remove a few jar dependencies. Can we create own own versions and dump commons-lang (and anything else while we are at it). I really hate dealing with DLL/Jar Hell and commons-lang is going to bit us in the future.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 7:18 am 
Hibernate Team
Hibernate Team

Joined: Tue Aug 26, 2003 6:10 am
Posts: 8615
Location: Neuchatel, Switzerland (Danish)
commons-lang is mainly used because of NestableException.

So, it is very likely we would make a NestableException in hibernate and just let go of commons-lang. (patches are welcome ;)

_________________
Max
Don't forget to rate


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 9:21 am 
Senior
Senior

Joined: Wed Aug 27, 2003 6:04 am
Posts: 161
Location: Linz, Austria
max wrote:
commons-lang is mainly used because of NestableException.

So, it is very likely we would make a NestableException in hibernate and just let go of commons-lang. (patches are welcome ;)


<rant>Nested exceptions have been introduced to J2SE way too late. They should at least have been in 1.3, then we wouldn't have all those problems... We would simply use standard exception nesting like now in J2SE-1.4-only apps.</rant>

More constructively speaking: We have introduced NestedRuntimeException and NestedCheckedException classes in Spring for exactly the same reason. We don't want to depend on commons-lang for such a minimal issue, and we don't want to make it hard for users to use the commons-lang release of their choice.

So I highly recommend that you use your own nestable exception base class to avoid unnecessary dependencies. BTW, I see that you also depend on commons-lang's ObjectUtils.equals; but that should be trivial to reimplement too.

You could also reconsider using commons-collections, it's quite large at 162 KB... As far as I see, you're just using SequencedHashMap and ReferenceMap. On the other hand, reinventing the wheel doesn't make much sense either. It's hard to decide, I guess.

Juergen


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 9:24 am 
Hibernate Team
Hibernate Team

Joined: Mon Aug 25, 2003 9:11 pm
Posts: 4592
Location: Switzerland
We talked about this and other issues wrt dependencies at JAOO and it's somewhere on the road map. I just have to find some time to write it down...

_________________
JAVA PERSISTENCE WITH HIBERNATE
http://jpwh.org
Get the book, training, and consulting for your Hibernate team.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 9:40 am 
Senior
Senior

Joined: Wed Aug 27, 2003 6:04 am
Posts: 161
Location: Linz, Austria
P.S.: Of course, keeping dependencies low is more important for Spring than it is for Hibernate. Hibernate is above 1 MB in terms of libraries in any case, targeting larger applications in the first place, while a Spring bean factory can even be embedded in an applet.

The latter just requires spring-beans.jar at 97 KB and commons-logging-api.jar at 22 KB, totaling at 120 KB. We're actually using it that way at werk3AT, besides usage as a full-blown J2EE application framework of course.

For Spring, additionally depending on commons-lang, commons-collections, and commons-beanutils (easy to imagine for a bean factory implementation) would mean 340 KB more, quadrupling the total library size in the applet case.

Juergen


Top
 Profile  
 
 Post subject:
PostPosted: Tue Oct 14, 2003 7:25 pm 
Hibernate Team
Hibernate Team

Joined: Tue Aug 26, 2003 12:50 pm
Posts: 5130
Location: Melbourne, Australia
commons-lang is now massively bloated and also seems to have some bizarre backward compatibility problems, so we should kick it out of Hibernate as soon as possible.


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 

All times are UTC - 5 hours [ DST ]


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
© Copyright 2014, Red Hat Inc. All rights reserved. JBoss and Hibernate are registered trademarks and servicemarks of Red Hat, Inc.