Hi,

as we use Query-by-Example very frequently in our application, the new API is allready a huge improvement for us. However we often have example objects where the data entered by the user is used as a prefix of the data to be displayed.

So what we need to do now is to append % to all propertys of the example object. It would be nice if the LIKE-Feature of the Example class could be extended to do this automatically.

We could patch this in easily, is there any need for such a feature, if yes we would submit a patch.

Michael

Ah. This is a good idea.


Perhaps an addWildcards() method, or something...?

As I am looking into this, I think it might probably be an idea to do include this with LikeExpression, too.

I have the automatic expansion of the value working with the Example-API, and writing some test-cases for it. Cant submit a patch right now, because the sourceforge CVS seems to be not working properly.

Hey, you are working against v21branch, right?

Hm yes, at least I think so :) Example shouldn't be in HEAD yet anyways if I get this right.

true!

I have submitted a patch to JIRA here http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-334

This adds the possibility to add automatic wildcards like this:

Example.create(exampleObject).enableLike(Example.MATCH_ANYWHERE)

You can use MATCH_ANYWHERE, MATCH_PREFIX and MATCH_SUFFIX to create patterns like %xxx%, xxx% and %xxx

I also found a bug with Example.ignoreCase, which actually was not working at all.

Probably it would be useful to delegate not only the sql-String generation but also the generation of the TypedValues to LikeExpression and EqExpression. The way it works now there is some duplicate logic here.

This was my first patch submitted for Hibernate, is the format, etc. correct?