change in default DiscriminatorValue in beta9?

3point · **Joined:** Fri Feb 10, 2006 2:57 am **Posts:** 14

I've been playing around with Beta9 from SVN and noticed that the defaulting for DiscriminatorValue has changed. I'm not sure if this is a bug or a change to be spec compliant? Thre is a note in the code about being "spec compliant"

If its a change to be spec compliant, the documentation needs to be changed:

Quote:

The default name of the discriminator column is TYPE, and (for Hibernate) the default discriminator value is the fully qualified class name.

- http://www.hibernate.org/hib_docs/annot ... le/#d0e775

Looks like change in bindEntity():

From:

Code:

...
if ( StringHelper.isEmpty( discriminatorValue ) ) {
        persistentClass.setDiscriminatorValue( persistentClass.getEntityName() );
}
...

To:

Code:

...
bindDiscriminatorValue();
...

calls into

Code:

   public void bindDiscriminatorValue() {
      if ( StringHelper.isEmpty( discriminatorValue ) ) {
            ...
            persistentClass.setDiscriminatorValue( name ); //Spec compliant
            ...
   }

If the behavior is to be consistent, I'd think you'd want:

Code:

persistentClass.setDiscriminatorValue( persistentClass.getEntityName() )

because "name" is the unqualified name of the class. If this is spec compliant, an FAQ is probably in order.

3point · **Joined:** Fri Feb 10, 2006 2:57 am **Posts:** 14

speaking of Beta9, it's marked as released in Jira but not available as a packaged download yet, just available in SVN.

emmanuel · **Posted:** Sat Mar 25, 2006 9:30 am

The spec has changed in this are hence the change.
I'm waiting some JBoss release before pushing out beta9

3point · **Joined:** Fri Feb 10, 2006 2:57 am **Posts:** 14

spec change - right. Guess we'll have to live with it. Seems pretty dumb to me - if you had two classes with the same name but different packages, you'd break with the out-of-the-box configuration.

guess I will have to add more annotations to my classes to keep the desired behavior.

anyhow, thanks for the clarification.

gschrader · **Joined:** Tue Dec 09, 2003 3:27 pm **Posts:** 21

I agree that this seems dumb, any possibility of Hibernate supporting an additional DiscriminatorType for fqcn?

emmanuel · **Posted:** Fri Mar 31, 2006 7:37 am

This is not dumb, fqcn required a huge column size.
Add a JIRA issue for flexible Hibernate dicriminator type.
this has nothing to dow ith the value though