QueryBuilder bombs on null String

mschipperheyn · **Joined:** Wed Nov 05, 2003 7:22 pm **Posts:** 211

Hi,

I have query like so

Code:

public class Item{
   @Field(index=Index.UN_TOKENIZED,store=Store.YES)
   @Column(length=255)
   public String getUrl() {
      return url;
   }
}

QueryBuilder qb = fts.getSearchFactory().buildQueryBuilder()
            .forEntity(Item.class).get();
Query q = sj.must(qb.keyword().onField("url").matching(item.getUrl())
               .createQuery());

This bombs if item.getUrl() is null. I get the message

Code:

org.hibernate.search.SearchException: Search parameter on field url could not be converted. Are the parameter and the field of the same type?Alternatively, apply the ignoreFieldBridge() option to pass String parameters
   at org.hibernate.search.query.dsl.impl.Helper.getAllTermsFromText(Helper.java:78)
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.getAllTermsFromText(ConnectedMultiFieldsTermQueryBuilder.java:173)
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.createQuery(ConnectedMultiFieldsTermQueryBuilder.java:98)
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.createQuery(ConnectedMultiFieldsTermQueryBuilder.java:73)

Why? Should I protect Hibernate against potential nulls? That would not make sense.

If I add the suggested ignoreFieldBridge, I get

Code:

org.hibernate.search.SearchException: Unable to search for null token on field url if field bridge is ignored.
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.buildSearchTerm(ConnectedMultiFieldsTermQueryBuilder.java:123)
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.createQuery(ConnectedMultiFieldsTermQueryBuilder.java:92)
   at org.hibernate.search.query.dsl.impl.ConnectedMultiFieldsTermQueryBuilder.createQuery(ConnectedMultiFieldsTermQueryBuilder.java:73)

hardy.ferentschik · **Posted:** Wed Jan 11, 2012 6:55 am

Hi,

Quote:

Why? Should I protect Hibernate against potential nulls? That would not make sense.

Why does it not make sense? null is normally not a valid search term. What would you expect?

--Hardy

mschipperheyn · **Joined:** Wed Nov 05, 2003 7:22 pm **Posts:** 211

I guess I would expect an ignore.

sanne.grinovero · **Posted:** Tue Jan 17, 2012 1:11 pm

Hi Marc,
sorry, I disagree. If it's an invalid term we should throw IllegalArgumentException at least, or SearchException like we do. This is generally useful as it helps spotting errors early, and most Java SE APIs do so as well so it's what an average Java developer would expect.

hardy.ferentschik · **Posted:** Tue Jan 17, 2012 1:19 pm

Right, an exception seems to be the right thing. null is just not a valid search term.

--Hardy

mschipperheyn · **Joined:** Wed Nov 05, 2003 7:22 pm **Posts:** 211

I understand that. Given the fluid approach of chaining methods in the API, I would prefer ignoring nulls as opposed to working with MustJunctions etc but I see the point.