Hello,
I am implementing my own ThreadLocalSessionContext handler and came across an issue.

When you want to implement a new class extending the CleanUpSynch, it is not possible to access the factory. The factory attribute is privat.

I suggest to make the factory attribute protected to have access to it from subclasses.
Please tell me if I am wrong or if I overlooked something.

Best Regards

Sebastian

Hibernate version:
3.1
Mapping documents:

Code between sessionFactory.openSession() and session.close():

Full stack trace of any exception that occurs:

Name and version of the database you are using:

The generated SQL (show_sql=true):

Debug level Hibernate log excerpt:

You are supposed to override this:

protected CleanupSynch buildCleanupSynch() {
return new CleanupSynch( factory );
}


And implement your own CleanupSynch class. You are not supposed to override the existing CleanupSynch. See ExtendedThreadLocalSessionContext.java in CaveatEmptor.

Hello Christian,

in ExtendedThreadLocalSessionContext the NoCleanupSynch in the Caveat Emptor example does extend the CleanUpSynch from the ThreadLocalSessionContext. See the snipped below.
I followed this proposal but wanted to access the factory in the afterCompletion and got the problem I explained.

In my humble opinion this is not pretty clear as example. Either the NoCleanupSynch example should not extend CleanUpSynch or the factory should be protected.

Best Regards and thank you for the feedback

Sebastian

......... snip ...........
protected CleanupSynch buildCleanupSynch() {
return new NoCleanupSynch(factory);
}
private static class NoCleanupSynch extends ThreadLocalSessionContext.CleanupSynch {
public NoCleanupSynch(SessionFactory factory) { super(factory); }
public void beforeCompletion() {}
public void afterCompletion(int i) {}
}

I've relaxed this in CVS.