Oddity in commitTransaction() in chap 8 HibernateUtil class

amezick · **Joined:** Mon Nov 03, 2003 11:48 pm **Posts:** 29

Code:

try{
  threadTransaction.set(null);
    if(tx!=null&&!tx.wasCommited()&&!tx.wasRolledBack())
      tx.commit();
      threadTransaction.set(null);
}catch(HibernateException ex){
  rollbackTransaction();
  throw new InfrastructureException(ex);
}

the first threadTransaction.set(null) is invalid because then you can't rollback. There will be nothing to rollback if the commit fails. Should the second threadTransaction.set(null) be within the if as the indentation suggests or outside of it as the braces suggest?

--Angus

christian · **Posted:** Fri Jul 09, 2004 8:43 am

I can not find the code you posted in either the MEAP chapter 8 or the CaveatEmptor download. Setting the threadlocal transaction to null before trying to rollback or commit it is fine.

christian · **Posted:** Fri Jul 09, 2004 8:45 am

Oh, I looked at the wrong method. Yes, you are right, the first call is incorrect and should have been removed in proofread. I'll make a note to get this fixed again. The CaveatEmptor download has the correct version.