hbm2java: boolean getter name style

dlipofsky · **Joined:** Wed Oct 31, 2007 9:16 pm **Posts:** 9

I am using hbm2java in ant (hibernate-tools-3.2.0beta9.jar).

I want to generate my getters/setters for booleans properties
like isFoobar and hasFoobar in the style of

public boolean getIsFoobar() { ... }
public boolean getHasFoobar() { ... }

instead it is doing

public boolean isFoobar() { ... }
public boolean isHasFoobar() { ... }

(in case you wonder, I need to do this for backwards
compatibility as I convert to hibernate)

Is there anyway to do this?

I tried changing the generated name in PojoPropertyAccessors.ftl
but that does not work, because it does not get changed for
toString()/hashCode()/equals() generation. And I can fix PojoToString.ftl
but I don't see anyway to fix PojoEqualsHashcode.ftl (since it is all
generated by a call to pojo.generateEquals() and pojo.generateHashCode()).

Thank you for your help.
- Dan

max · **Posted:** Thu Nov 01, 2007 6:32 am

what is your input here ?

if the property name is "hasFoobar" it must be "isHasFoobar" to be correct.

dlipofsky · **Joined:** Wed Oct 31, 2007 9:16 pm **Posts:** 9

For booleans either getXyz() for isXyz() is correct.
This has been a choice for POJO beans since the
very beginning of Java. I prefer getXyz() because of the consistency.
But more importantly we are converting EJBs to hibernate,
we used XDoclet to generate the data-objects for EJBs,
and it used the getXyz() form when generating getters for booleans.
So to avoid changing my code everywhere I would like to
have hbm2java also generate the getXyz() form.

dlipofsky · **Joined:** Wed Oct 31, 2007 9:16 pm **Posts:** 9

I have confirmed with the Java Bean Spec 1.01 that either form is acceptable. See http://java.sun.com/products/javabeans/docs/spec.html

And I looked at the code so I am pretty sure there is no way to choose.

I have an idea for a patch.
Can anyone tell me the best way to submit it?

Code:

--- tools/src/java/org/hibernate/tool/hbm2x/pojo/BasicPOJOClass.java    (revision 14167)
+++ tools/src/java/org/hibernate/tool/hbm2x/pojo/BasicPOJOClass.java    (working copy)
@@ -566,7 +566,11 @@
         * @return String
         */
        public String getGetterSignature(Property p) {
-               String prefix = c2j.getJavaTypeName( p, false).equals( "boolean" ) ? "is" : "get";
+               String prefix = "get";
+               if ( c2j.getJavaTypeName(p, false).equals( "boolean" ) ) {
+                       MetaAttribute bgp = p.getMetaAttribute("boolean-getter-prefix");
+                       prefix = (bgp == null) ? "is" : MetaAttributeHelper.getMetaAsString(bgp);
+               }
                return prefix + beanCapitalize( p.getName() );
        }

Then you can add

Code:

and get what you want.

max · **Posted:** Thu Nov 01, 2007 5:57 pm

ok - now i understand what you want.

I don't like the fix though.

The workaround you can do is to customize the *.ftl's to generate a "getter" for every boolean property that will delegate to the "isser"

dlipofsky · **Joined:** Wed Oct 31, 2007 9:16 pm **Posts:** 9

So you are saying to have both a getXyz() and a isXyz()?
Yes, that would work. I prefer my patch (so you just have one getter),
but I certainly don't want to maintain my own version of hbm2java :-)

In case anyone else needs it here is the code I added to PojoPropertyAccessors.ftl:

Code:

<#if pojo.getGetterSignature(property).startsWith("is") >
    /**
     * Calls ${pojo.getGetterSignature(property)}().
     * For backward compatability with old code that expects "get" instead of "is".
     */
    ${pojo.getPropertyGetModifiers(property)} ${pojo.getJavaTypeName(property, jdk5)} get${pojo.getPropertyName(property)}() {
        return ${pojo.getGetterSignature(property)}();
    }
</#if>

max · **Posted:** Fri Nov 02, 2007 2:23 am

exactly - also thinks this represents what you are actually doing (working around old code generation that didn't use the more proper "is" ;)