argument order in hbm2java-generated constructors

nadams · **Posted:** Fri Nov 04, 2005 6:25 pm

With recent check ins, the hbm2java is now generating full & minimal constructors. Excellent! I have this issue though:

It seems the argument order generated for full constructors is different than in Hibernate2. The new order appears to parallel the order properties are appear in the mapping file.

Is the generated argument order now defined to match the mapping file (would be a good thing in my opinion) or is an artifact of the implementation & could change with each release?

Similarly for minimal constructors -- with the additional issue that the selection of what constitutes minimal seems to have changed also.

Thanks for any guidance

max · **Posted:** Sat Nov 05, 2005 5:06 am

this was why i hesitated to add it in the first place - not possible to get really right ;)

Any ways, the order is the order in which hibernate meta model returns the properties (and that should reflect the order from the mapping files as much as possible)

What has changed on the minimal definition ?

pmularien · **Posted:** Mon Nov 07, 2005 1:46 pm

I noticed that the version property is now showing up in the minimal constructor and the full constructor - this didn't happen before, at least for me.

max · **Posted:** Mon Nov 07, 2005 3:48 pm

ahh...that one should probably be removed yes. put it in jira.

pmularien · **Posted:** Tue Nov 08, 2005 12:15 pm

Done - HBX-474. Thanks max!

nadams · **Posted:** Wed Nov 16, 2005 5:51 pm

max wrote:

What has changed on the minimal definition ?

In the appended mapping file for a node in a tree, the old minimal constructor had 3 arguments -- position, vocabulary, children, the new has just 2, position and vocabulary. The new behavior makes more sense to me than the old, so maybe this counts as a fixed bug rather than changed behavior.

Code:

<class name="VocabularyItem" ... >
    ...    
    <set name="children" inverse="true" sort="natural">
        <key column="PARENT_ID"/>
        <one-to-many class="VocabularyItem"/>
    </set>   
    
    <many-to-one name="parent" class="VocabularyItem" 
         not-null="false" column="PARENT_ID"/>
    
    <property name="position" type="integer" not-null="true" />

    <many-to-one name="vocabulary" class="Vocabulary"
            column="VOCAB_ID" not-null="true"/>
            
</class>

nadams · **Posted:** Thu Nov 17, 2005 7:25 pm

nadams wrote:

In the appended mapping file for a node in a tree, the old minimal constructor had 3 arguments -- position, vocabulary, children, the new has just 2, position and vocabulary. The new behavior makes more sense to me than the old, so maybe this counts as a fixed bug rather than changed behavior.

After a little more messing around I'm not sure if the new behavior is a bug or a feature. What is the contract of the minimal constructor?

max · **Posted:** Thu Nov 17, 2005 7:52 pm

minimal = non-id (except assigned), non-version and not nullable