I upgrade to eclipse 3.1.1,gef 3.1.1,emf 3.1.1 and wtp-sdk-M20050827

Tools (last cvs before 15 minutes,too) throw exception when I open any xml file like this (in error log only, it work )
model has no JFace adapter factory

when i typing in editor exception is :
Error 2005-10-07 21:06:44.524 A structured model client, org.hibernate.eclipse.mapper.views.contentoutline.JFaceNodeAdapterForXML@16a0733 threw following exception during adapter notification (REMOVE )
java.lang.NullPointerException
at org.hibernate.eclipse.mapper.views.contentoutline.JFaceNodeAdapterFactoryForXML.getListeners(JFaceNodeAdapterFactoryForXML.java:60)
at org.eclipse.wst.xml.ui.internal.contentoutline.JFaceNodeAdapter.notifyChanged(JFaceNodeAdapter.java:393)
at org.eclipse.wst.sse.core.internal.provisional.AbstractNotifier.notify(AbstractNotifier.java:202)
at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.notify(XMLModelNotifierImpl.java:235)
at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.notifyDeferred(XMLModelNotifierImpl.java:323)
at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.endChanging(XMLModelNotifierImpl.java:175)
at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.changedModel(DOMModelImpl.java:161)
at org.eclipse.wst.sse.core.internal.model.AbstractStructuredModel$DocumentToModelNotifier.regionChanged(AbstractStructuredModel.java:163)
at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument._fireEvent(BasicStructuredDocument.java:548)
at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.fireStructuredDocumentEvent(BasicStructuredDocument.java:1196)
at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.internalReplaceText(BasicStructuredDocument.java:1860)
at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2297)
at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.access$0(JobSafeStructuredDocument.java:1)
at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument$1.run(JobSafeStructuredDocument.java:100)
at org.eclipse.wst.sse.ui.internal.editor.EditorExecutionContext.execute(EditorExecutionContext.java:43)
at org.eclipse.wst.sse.core.internal.text.JobSafeStructuredDocument.replaceText(JobSafeStructuredDocument.java:110)
at org.eclipse.wst.sse.core.internal.text.BasicStructuredDocument.replaceText(BasicStructuredDocument.java:2293)
at org.eclipse.wst.sse.ui.internal.StructuredDocumentToTextAdapter.replaceTextRange(StructuredDocumentToTextAdapter.java:1187)
at org.eclipse.swt.custom.StyledText.modifyContent(StyledText.java:5787)
at org.eclipse.swt.custom.StyledText.sendKeyEvent(StyledText.java:6625)
at org.eclipse.swt.custom.StyledText.doContent(StyledText.java:2592)
at org.eclipse.swt.custom.StyledText.handleKey(StyledText.java:5098)
at org.eclipse.swt.custom.StyledText.handleKeyDown(StyledText.java:5124)
at org.eclipse.swt.custom.StyledText$7.handleEvent(StyledText.java:4857)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1021)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1045)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1030)
at org.eclipse.swt.widgets.Widget.sendIMKeyEvent(Widget.java:1107)
at org.eclipse.swt.widgets.Control.gtk_commit(Control.java:1851)
at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1355)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:3442)
at org.eclipse.swt.internal.gtk.OS._gtk_im_context_filter_keypress(Native Method)
at org.eclipse.swt.internal.gtk.OS.gtk_im_context_filter_keypress(OS.java:4327)
at org.eclipse.swt.widgets.Control.filterKey(Control.java:1428)
at org.eclipse.swt.widgets.Control.gtk_key_press_event(Control.java:1957)
at org.eclipse.swt.widgets.Composite.gtk_key_press_event(Composite.java:560)
at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1365)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:3442)
at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:4777)
at org.eclipse.swt.widgets.Display.eventProc(Display.java:1067)
at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:1158)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2570)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1699)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1663)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:367)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103)
at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:226)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:376)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:163)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.core.launcher.Main.invokeFramework(Main.java:334)
at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
at org.eclipse.core.launcher.Main.run(Main.java:973)
at org.eclipse.core.launcher.Main.main(Main.java:948)

dont use WTP releases that are incompatible with WTP 0.7

/max

this is 0.7 maintenance release from Sep 27
I see now that exists 0.7.1 from Sep 27 and is it fine ?

i have not tested with 0.7.1 - only with 0.7.

my install is 0.7.1 (before one build) and it doesn't work - i download 0.7.1 now and check it - maintenance release have more bugs resolved and try it , please

add :

I have spring-ide and exists similar outline in spring-ide's xml editor - it work fine

eh - and they change api's thus if I start using it 98% of our users cannot run this.

Thus i won't move until WTP has some stability

eh and your point being ? If there is an issue feel free to fix it and submit a patch.

That some other plugin does not fail with WTP 0.7.x/1.0 just means they are not using the features we need to provide code completion et.al.

There are big changes going on inside the WTP XML editor which if we should keep up with every change we would not have any progress; and users would not be able to use Hibernate tools in the mean while.

you can try on both 0.7 or 0.7.1

I see error - Problem is in HibernateXMLContentOutlineConfiguration

line 15
IJFaceNodeAdapterFactory realFactory = super.getFactory();

return null and JFaceNodeAdapterFactoryForXML#getListener() doesn't check for null

This is enough :

public Collection getListeners() {
return realFactory.getListeners();
}

to

public Collection getListeners() {
if (realFactory == null)
return Collections.EMPTY_LIST;
return realFactory.getListeners();
}

We need similar for addListener and removeListsner in this class, but this methods are unused

regards

eh - could it not be that our code actually NEED that factory - then it is not enough to just nullcheck

you do it

btw. i dont get this error when running with wtp-0.7.1 and all its deps.

I have eclipse 3.1.1, wtp 0.7.1 (now), emf 3.1.1,gef 3.1.1 and vep 1.1.0.1 (instead jem, but it is same - jem is from vep projects) - all projects are sdk version)

I use last cvs hibernate tools and all work on linux

I get error

what class you get in line 15 in HibernateXMLContentOutlineConfiguration.java

IJFaceNodeAdapterFactory realFactory = super.getFactory();

what is realFactory after this command

Thanks

Max,
I forget - error is visible only in error log view (pde runtime) - tou can't see error if yu haven't error log view opened

Max,
I complete clean eclipse and it is fine, now (almost) - it work fine in runtime workspace (with tools beta1), but I can't yet set good in normal eclipse (like plugin)

eclipse 3.1 (3.1.1 too) have hard problem with cleaning plugins (exporting plugins and features too, but it is old problem)

wtp project have special schema for versioning - I think that nobody unedrestand it

I'm sorry, hibernate tools are fine