I do not know if this already has been posted. I have found a way around this and just want to let you know.


Having the example below won't work with the id having name "rSeisProcActS" but using "rseisProcActS" works !


<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC
"-//Hibernate/Hibernate Mapping DTD 2.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-2.0.dtd" >

<hibernate-mapping>

<class
name="com.xyz.model.PbRSeisProcActV"
table="PB_R_SEIS_PROC_ACT_V"
>

<id
name="rSeisProcActS"
column="R_SEIS_PROC_ACT_S"
type="java.lang.String"
length="19">
<generator class="com.xyz.hibernate.SurrogateKeyGenerator"/>
</id>

<property
name="processingNm"
column="PROCESSING_NM"
type="java.lang.String"
length="40"
/>
<property
name="superKind"
column="SUPER_KIND"
type="java.lang.String"
length="40"
/>
<property
name="description"
column="DESCRIPTION"
type="java.lang.String"
length="2000"
/>


<!-- associations -->

</class>
</hibernate-mapping>



Gives : Could not find a setter for property rSeisProcActS in class com.xyz.model.PbRSeisProcActV

But the generated java looks correct like

package com.xyz.model;

import java.io.Serializable;
import org.apache.commons.lang.builder.EqualsBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.apache.commons.lang.builder.ToStringBuilder;

/** @author Hibernate CodeGenerator */
public class PbRSeisProcActV implements Serializable {

/** identifier field */
private String rSeisProcActS;

/** nullable persistent field */
private String processingNm;

/** nullable persistent field */
private String superKind;

/** nullable persistent field */
private String description;

/** full constructor */
public PbRSeisProcActV(String processingNm, String superKind, String description) {
this.processingNm = processingNm;
this.superKind = superKind;
this.description = description;
}

/** default constructor */
public PbRSeisProcActV() {
}

public String getRSeisProcActS() {
return this.rSeisProcActS;
}

public void setRSeisProcActS(String rSeisProcActS) {
this.rSeisProcActS = rSeisProcActS;
}

public String getProcessingNm() {
return this.processingNm;
}

public void setProcessingNm(String processingNm) {
this.processingNm = processingNm;
}

public String getSuperKind() {
return this.superKind;
}

public void setSuperKind(String superKind) {
this.superKind = superKind;
}

public String getDescription() {
return this.description;
}

public void setDescription(String description) {
this.description = description;
}

public String toString() {
return new ToStringBuilder(this)
.append("rSeisProcActS", getRSeisProcActS())
.toString();
}

public boolean equals(Object other) {
if ( !(other instanceof PbRSeisProcActV) ) return false;
PbRSeisProcActV castOther = (PbRSeisProcActV) other;
return new EqualsBuilder()
.append(this.getRSeisProcActS(), castOther.getRSeisProcActS())
.isEquals();
}

public int hashCode() {
return new HashCodeBuilder()
.append(getRSeisProcActS())
.toHashCode();
}

}


Making this correction to the mapping file (setting name=rseisProcActS" ) fixes the problem.

Must be a error in the code which gets confused with the uppercase in the 2. char



<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC
"-//Hibernate/Hibernate Mapping DTD 2.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-2.0.dtd" >

<hibernate-mapping>

<class
name="com.xyz.model.PbRSeisProcActV"
table="PB_R_SEIS_PROC_ACT_V"
>

<id
name="rseisProcActS"
column="R_SEIS_PROC_ACT_S"
type="java.lang.String"
length="19">
<generator class="com.xyz.hibernate.SurrogateKeyGenerator"/>
</id>

<property
name="processingNm"
column="PROCESSING_NM"
type="java.lang.String"
length="40"
/>
<property
name="superKind"
column="SUPER_KIND"
type="java.lang.String"
length="40"
/>
<property
name="description"
column="DESCRIPTION"
type="java.lang.String"
length="2000"
/>


<!-- associations -->

</class>
</hibernate-mapping>


The generated code for this is (correctly as well)

package com.xyz.model;

import java.io.Serializable;
import org.apache.commons.lang.builder.EqualsBuilder;
import org.apache.commons.lang.builder.HashCodeBuilder;
import org.apache.commons.lang.builder.ToStringBuilder;

/** @author Hibernate CodeGenerator */
public class PbRSeisProcActV implements Serializable {

/** identifier field */
private String rseisProcActS;

/** nullable persistent field */
private String processingNm;

/** nullable persistent field */
private String superKind;

/** nullable persistent field */
private String description;

/** full constructor */
public PbRSeisProcActV(String processingNm, String superKind, String description) {
this.processingNm = processingNm;
this.superKind = superKind;
this.description = description;
}

/** default constructor */
public PbRSeisProcActV() {
}

public String getRseisProcActS() {
return this.rseisProcActS;
}

public void setRseisProcActS(String rseisProcActS) {
this.rseisProcActS = rseisProcActS;
}

public String getProcessingNm() {
return this.processingNm;
}

public void setProcessingNm(String processingNm) {
this.processingNm = processingNm;
}

public String getSuperKind() {
return this.superKind;
}

public void setSuperKind(String superKind) {
this.superKind = superKind;
}

public String getDescription() {
return this.description;
}

public void setDescription(String description) {
this.description = description;
}

public String toString() {
return new ToStringBuilder(this)
.append("rseisProcActS", getRseisProcActS())
.toString();
}

public boolean equals(Object other) {
if ( !(other instanceof PbRSeisProcActV) ) return false;
PbRSeisProcActV castOther = (PbRSeisProcActV) other;
return new EqualsBuilder()
.append(this.getRseisProcActS(), castOther.getRseisProcActS())
.isEquals();
}

public int hashCode() {
return new HashCodeBuilder()
.append(getRseisProcActS())
.toHashCode();
}

}



Well anyhow - somwhere ther eis a bug which dose not like property Names to have a upper case char in 2. position....

If your getter is called getRseisProcActS, the property has to be called rseisProcActS as in the JavaBean spec.

You did not say how you "generated" the mapping. It would help to know. In anycase, Middlegen did have this problem. The fix was already in CVS.

Yes - middlegen was used. But its really irrelevant. As long as the generated Java is correct it must be a bug in Hibernate ?
I see middlegen has "fixed" it by not making sunch property names but that is just a workaround and not explaining why it dose not work

Anyhow - I just wanted to let you know. Still think Hibernate is a great product.

B

Reply to Michael - you are right - and that is also the one which works. (second in my example) but the first example (the one which fails) has a property called

rSeisProcActS

and the setter and getter are generated (correctly according to spec) as

public String getRSeisProcActS() {
return this.rSeisProcActS;
}

public void setRSeisProcActS(String rSeisProcActS) {
this.rSeisProcActS = rSeisProcActS;
}


but THAT fails !

B

I'm having the same problem:

I have a property with an upper case char in second position:



the java getter is correctly generated by hbm2java (IMHO):


but when I try an Configuration.addFile() I get the error:


Changing the name to propKey or something like this works.
Am I'm missing something, is this expected JavaBeans behavior?

shouldn't it be name="PKey" ?

No. - As Michale stated - The Java Bean spec uppercases the first letter in the getter. So a property with the name "pKey" get's the correct getter "getPKey". So the XML file is correct and the getter is correctly generated - still Hibernate fails.

I still beleave there is something rotten.

Im not going to say right or wrong as I am not a Bean Spec expert. Having said that, the Middlegen Plugin (in CVS) will not allow the second char to be uppercase in this situation now thus avoiding this issue.

That is good - however it doesn't help me, since I need my Middlegen properties file, which I have to edit by hand to change the 2nd char to lowercase.

But leaving Middlegen out:


is a perfectly valid Hibernate mapping, so I would hibernate expect to handle this without errors.

The source of that problem is in using Introspector.decapitalize() method. From javadoc: when there is more than one character and both the first and second characters are upper case, we leave it alone. As this ugly (decapitalize otput is capitalized!) behaviour is well documented, it is not considered to be a bug and will not be fixed. Thus we have to ask Hibernate team to write their own method instead of using a standard but inappropriate one.

Create a JIRA entry for this with your comment and a reference to this thread. This way it will be forgotten as Hiernate v3.0 is the primary focus at the moment.

Negative. Please don't create any more JIRA issues relating to this, since I will just reject them.

I'm completely confused. Will this behaviour be changed in 3.0 or not? As I've already mentioned, Sun doesn't plan to change decapitalize implementation and using such names in databases is quite common (e_mail, a_bomb etc). I use middlegen to generate .hbm files, then have to edit them manually and only then may call hbm2java. Does a better alternative exist?

Hmm - I'm also a little confused. Sounds like there must have been a dicussion around this before ? Any link ?

It cooks down to the fact that if

1) I create a mapping file with a property which has a Uppercase letter as 2. char, example rAbc
2) Use hbm2java to create java files

than it won't work.

We can leave all discussions around Middlegen etc out of this and focus on the fact that a fully valid property name of "rAbc" + hbm2java generated java won't work. But maybe this has a deeper reason which I am not aware of .... anyhow it's not a big deal - so we could perhapst just add this "feature" to the FAQ ?

Thanx again
B-)