Hibernate Books

All times are UTC - 5 hours [ DST ]



Post new topic Reply to topic  [ 2 posts ] 
Author Message
 Post subject: Request for extended message interpolation
PostPosted: Wed Jun 15, 2011 5:20 pm 
Newbie

Joined: Wed Jun 15, 2011 5:02 pm
Posts: 3
Hi Emanuel

I'm using the Hibernate Validators since the day it got released. I wrote some extensions which also might be useful to other users:

I extended the MessageInterpolator so that I can use the rootBean, leafBean and the invalidValue in the message templates. Further I added support for nested properties. Here are some samples for (extended) message templates: - "The age of {leafBean.firstname} {leafBean.lastname} must be between {min} and {max} but is {invalidValue}." => "The age of John Doe must be between 18 and 65 but is 17." - "Error on {rootBean}: The the transaction's ({leafBean.transactionId}) amount ({invalidValue}) is too low." - "{invalidValue} is not a valid account number." While this information is unnecessary while you are typing the data and see the whole record, it might be essential if the input is a file and the message is written to a log.

It would also useful to provide some custom properties in the MessageInterpolator context:

beanValidator.validateValue(Person.class, "firstName", person.getFirstName); ... ctx.put("fieldName", "first name"); msgInterpolator.interpolate(constraintViolation.getMessageTemplate(), ctx); - "The field '{context.fieldName}' must not be empty."

While the leafBean is available as "validatedValue" in the MessageInterpolator.Context, I had to extend the context to provide the other values.

The validator has only access to the validated object and the annotation. It is not always possible and reasonable to set the context information on the validated object. It would be good to have some context available in the validator. Now I pass the context information through a threadlocal variable which is very ugly and error prone. E.g. a validator could check if a value is equal to an entry of a dynamic list which depends on the context.

Sometimes it would be useful to pass some context to the validator:
Code:
validateBean(Object validationContext, T object, Class<?>... groups)
validateProperty(Object validationContext, T object, String propertyName, Class<?>... groups);
...

public class MyValidator implements javax.validation.ConstraintValidator<MyConstraint, MyObject> {
   public boolean isValid(MyObject myObject, ConstraintValidatorContext context) {
            ((MyService) context.getValidatorContext()).doSomeComplexValidation(myObject);
        }


Of course time consuming validation should not be triggered too often. A constaint causing such a validation would typically not define the Default.class group.

See also:
http://relation.to/Bloggers/JSRBeanVali ... mment19490

Regards René


Top
 Profile  
 
 Post subject: Re: Request for extended message interpolation
PostPosted: Mon Jul 18, 2011 8:30 am 
Hibernate Team
Hibernate Team

Joined: Sun Sep 14, 2003 3:54 am
Posts: 7179
Location: Atlanta, USA
Hi Rene,
Sorry I have not replied before.
I've opened https://hibernate.onjira.com/browse/BVAL-233 let's discuss your proposal here.

_________________
Emmanuel
Check Hibernate Search in Action out


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC - 5 hours [ DST ]


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
© Copyright 2014, Red Hat Inc. All rights reserved. JBoss and Hibernate are registered trademarks and servicemarks of Red Hat, Inc.