I am quite a newbie using NHibernate, but I am pretty sure that there is an error in the implementation of BasicCollectionPersister and/or AbstractCollectionPersister.

I was trying to use the <idbag> mapping, with no success. This is the mapping:


And the following error was occurring:



After some debugging, I understood what was happening: NHibernate was trying to assign a value to the field PREFERENCIA_USUARIO.ID_PREFERENCIA_USUARIO, which is an IDENTITY Sql Server field.

The value being assigned was NHibernate.Id.IdentityGenerator.

It seems that AbstractCollectionPersister and BasicCollectionPersister are not dealing correctly with IDENTITY PK's (unlike SingleTableEntityPersister, which correctly generates an insert without the IDENTITY field).

I have made the following changes, to allow the insertion of the <idbag> mapping:

- NHibernate.Persister.Collection.BasicCollectionPersister.GenerateInsertRowString method

Replaced with

- NHibernate.Persister.Collection.AbstractCollectionPersister.Recreate method

Same as above.

These changes seemed to work, but I cannot tell for sure that it is THE right way to do it...

Any comments? :-)

This is a known bug, NH-364 in JIRA. I believe the fix is not so trivial but I don't remember the details right now.

Yeah, I've just seen the JIRA issue... Sorry about posting about a bug already known...

Although the modification I've made has fixed my specific problem, I can easily understand that perhaps a more "robust" fix must be made...

But at least it is a temporary solution... I hope it helps somebody else out there... :-)

BTW, this new version of NHibernate is great, I really appreciate the generics support.

rsenna,

I was having the same issue with version 1.2.0.GA. I tried the code change you suggested but now I get this exception:

{NHibernate.ADOException: could not insert collection rows: [Finning.CustomerPortal.Entity.NewUser.Roles#1] ---> System.IndexOutOfRangeException: Invalid index 2 for this SqlParameterCollection with Count=2.
at System.Data.SqlClient.SqlParameterCollection.RangeCheck(Int32 index)
at System.Data.SqlClient.SqlParameterCollection.GetParameter(Int32 index)
at System.Data.Common.DbParameterCollection.System.Collections.IList.get_Item(Int32 index)
at NHibernate.Type.Int32Type.Set(IDbCommand cmd, Object value, Int32 index) in C:\nhib_src\nhibernate\src\NHibernate\Type\Int32Type.cs:line 57
at NHibernate.Type.NullableType.NullSafeSet(IDbCommand cmd, Object value, Int32 index) in C:\nhib_src\nhibernate\src\NHibernate\Type\NullableType.cs:line 197
at NHibernate.Type.NullableType.NullSafeSet(IDbCommand st, Object value, Int32 index, Boolean[] settable, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Type\NullableType.cs:line 138
at NHibernate.Type.ManyToOneType.NullSafeSet(IDbCommand st, Object value, Int32 index, Boolean[] settable, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Type\ManyToOneType.cs:line 62
at NHibernate.Persister.Collection.AbstractCollectionPersister.WriteElement(IDbCommand st, Object elt, Int32 i, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 610
at NHibernate.Persister.Collection.AbstractCollectionPersister.InsertRows(IPersistentCollection collection, Object id, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 1136
--- End of inner exception stack trace ---
at NHibernate.Persister.Collection.AbstractCollectionPersister.InsertRows(IPersistentCollection collection, Object id, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 1161
at NHibernate.Impl.ScheduledCollectionUpdate.Execute() in C:\nhib_src\nhibernate\src\NHibernate\Impl\ScheduledCollectionUpdate.cs:line 78
at NHibernate.Impl.SessionImpl.Execute(IExecutable executable) in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3280
at NHibernate.Impl.SessionImpl.ExecuteAll(IList list) in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3259
at NHibernate.Impl.SessionImpl.Execute() in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3223
at NHibernate.Impl.SessionImpl.Flush() in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3057
at NHibernateTest.Program.Main(String[] args) in D:\CHumber\My Documents\Visual Studio 2005\Projects\NHibernateTest\NHibernateTest\Program.cs:line 44}

Did you ever come across this?

rsenna,

I was having the same issue with version 1.2.0.GA. I tried the code change you suggested but now I get this exception:

{NHibernate.ADOException: could not insert collection rows: [xxx.Entity.NewUser.Roles#1] ---> System.IndexOutOfRangeException: Invalid index 2 for this SqlParameterCollection with Count=2.
at System.Data.SqlClient.SqlParameterCollection.RangeCheck(Int32 index)
at System.Data.SqlClient.SqlParameterCollection.GetParameter(Int32 index)
at System.Data.Common.DbParameterCollection.System.Collections.IList.get_Item(Int32 index)
at NHibernate.Type.Int32Type.Set(IDbCommand cmd, Object value, Int32 index) in C:\nhib_src\nhibernate\src\NHibernate\Type\Int32Type.cs:line 57
at NHibernate.Type.NullableType.NullSafeSet(IDbCommand cmd, Object value, Int32 index) in C:\nhib_src\nhibernate\src\NHibernate\Type\NullableType.cs:line 197
at NHibernate.Type.NullableType.NullSafeSet(IDbCommand st, Object value, Int32 index, Boolean[] settable, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Type\NullableType.cs:line 138
at NHibernate.Type.ManyToOneType.NullSafeSet(IDbCommand st, Object value, Int32 index, Boolean[] settable, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Type\ManyToOneType.cs:line 62
at NHibernate.Persister.Collection.AbstractCollectionPersister.WriteElement(IDbCommand st, Object elt, Int32 i, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 610
at NHibernate.Persister.Collection.AbstractCollectionPersister.InsertRows(IPersistentCollection collection, Object id, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 1136
--- End of inner exception stack trace ---
at NHibernate.Persister.Collection.AbstractCollectionPersister.InsertRows(IPersistentCollection collection, Object id, ISessionImplementor session) in C:\nhib_src\nhibernate\src\NHibernate\Persister\Collection\AbstractCollectionPersister.cs:line 1161
at NHibernate.Impl.ScheduledCollectionUpdate.Execute() in C:\nhib_src\nhibernate\src\NHibernate\Impl\ScheduledCollectionUpdate.cs:line 78
at NHibernate.Impl.SessionImpl.Execute(IExecutable executable) in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3280
at NHibernate.Impl.SessionImpl.ExecuteAll(IList list) in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3259
at NHibernate.Impl.SessionImpl.Execute() in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3223
at NHibernate.Impl.SessionImpl.Flush() in C:\nhib_src\nhibernate\src\NHibernate\Impl\SessionImpl.cs:line 3057
at NHibernateTest.Program.Main(String[] args) in D:\CHumber\My Documents\Visual Studio 2005\Projects\NHibernateTest\NHibernateTest\Program.cs:line 44}

Did you ever come across this?