Hi. I'm hoping someone here can confirm this is a bug in NHibernate (v. 1.0.2):

If flush() is called after ITransaction.Rollback(), the data in the transaction is NOT rolled back unless a flush has already been executed.

To duplicate:



The change is saved! This means that I need to be careful not to invoke any code that might trigger a flush in any finally clause in my application. Seems like a bug.

Note that in contrast to the above, if a flush occurs prior to the rollback, the transaction begins in the DB like you'd expect. In other words, the following code works fine:




It seems clear that at least one of these two behaviors is incorrect. Can someone let me know how to resolve this?

No, that is the expected behavior, I am afraid.

The issue here is that transaction rollback is not going to modify the state of an object in memory.
When Flush() is called later on, it understand that there are unsaved changes and attempts to save them.

Hmmm... currently my architecture flushes before a request ends. Is this a mistake?

What is the recommended way to handle exceptions in a transaction? Rollback and close the session immediately?

You could try evicting the offending entities.