Hellow

I'm using Castle's NHibernateIntegration Facility to work with NHibernate. It allows me to define more than one SessionFactory configuration and many more....
It has its own xml configuration, so i do not need to have NH configuration section in app.config (so Environment.Properties Hashtable is empty!). It reads the configuration, creates Configuration object and builds session factory based on it. Everything works fine with one exception - CommandTimeout settings. This value is copied to SessionFactory's Settings class but it is never used! Only place where CommandTimeout of newly created IDbCommand is set is in DriverBase.GenerateCommand and the value is read from Environment.Properties ......which is empty in my case....
So my questions is: It is intention that CommandTimeout configuration value is global, same for all SessionFactories even that it is present on SessionFactory Settings class ?

Thanx
Liwoj

Hibernate version: 1.0.2.0

Hmm, it wasn't intended and is certainly a bug. Created NH-709 for it. You're welcome to provide a patch ;-)

ok :-)
as i see it, the best place for setting command timeout is DriverBase (as it is now) but drivers has no access to session factory instance (because there can be more factories that share one driver, is that right?) and thus has no access to factory's settings....
We can do 2 things:
1) move the actual code that sets CommandTimeout from DriverBase to BatcherImpl.Generate
2) Add command timeout (int) parameter to DriverBase.GenerateCommand method....

What do You think ?

Liwoj

I worked on the relevant code today so I just went ahead and fixed it (by making some design changes). You can grab the current SVN version if you want to see the fix.

Wanted to ask what is going on with JetDriver.cs? It has not been compiling for couple of days already... Last time it was easy to fix, but this time I'm not sure how it should be changed.

Maybe we should set up some continues integration server (like CrusieControl.net)?

Gert

I will bring it up to date, I'm just working in Visual Studio with a reduced solution (NHibernate-2.0.sln) which only has four projects, JetDriver not being one of them so I don't notice when I break it. I will fix it tomorrow.

Yes, a CC.NET server would be nice to have.

Writing an ccnet configuration for build is fairly easy, I can do it (actually already did :-) ) But I do not have computer where to host the CC.NET server...

Gert