These old forums are deprecated now and set to read-only. We are waiting for you on our new forums!
More modern, Discourse-based and with GitHub/Google/Twitter authentication built-in.

All times are UTC - 5 hours [ DST ]



Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 4 posts ] 
Author Message
 Post subject: ImportAttribute (ping KPixel)
PostPosted: Thu Aug 17, 2006 6:05 am 
Beginner
Beginner

Joined: Wed Apr 19, 2006 9:16 am
Posts: 24
Hi,
I couldn't get the ImportAttribute to be serialized, so I've made some changes to get things to work (that is: in a way that I'd like them to work ;)).

In general, the changes consist of allowing the ImportAttribute to be declared on assemblies, and generating an <assemblyname>.imports.hbm.xml mapping file when serializing an assembly.

If you're (or anyone else is) interested in the modifications, let me know.

(I'm going to look into serializing an import declaration on other targets too, but getting a centralized imports mapping file was my personal target).

_________________
regards,
Willem van Rumpt


Top
 Profile  
 
 Post subject:
PostPosted: Thu Aug 17, 2006 2:44 pm 
Contributor
Contributor

Joined: Thu May 12, 2005 9:45 am
Posts: 593
Location: nhibernate.org
IMHO, <import> are the kind of things which are better of in a separated hbm.xml file with <query>, <sql-query>, etc.

Anyway, feel free to create a Jira issue for that and attach your patch :)
http://jira.nhibernate.org/

_________________
Pierre Henri Kuaté.
Get NHibernate in Action Now!


Top
 Profile  
 
 Post subject:
PostPosted: Fri Aug 18, 2006 1:46 am 
Beginner
Beginner

Joined: Wed Apr 19, 2006 9:16 am
Posts: 24
KPixel wrote:
IMHO, <import> are the kind of things which are better of in a separated hbm.xml file with <query>, <sql-query>, etc.

Anyway, feel free to create a Jira issue for that and attach your patch :)
http://jira.nhibernate.org/


Well, basically, that's what it does: It generates a separate hbm.xml file for imports per assembly. I'll have a look again to see if I'm happy with it, and upload the patches :)

Any particular way of marking the changes?

_________________
regards,
Willem van Rumpt


Top
 Profile  
 
 Post subject:
PostPosted: Fri Aug 18, 2006 9:52 pm 
Contributor
Contributor

Joined: Thu May 12, 2005 9:45 am
Posts: 593
Location: nhibernate.org
Willem van Rumpt wrote:
Any particular way of marking the changes?


You can read: How do I submit a patch for Subversion? and How to prepare a (unified) patch.

_________________
Pierre Henri Kuaté.
Get NHibernate in Action Now!


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 4 posts ] 

All times are UTC - 5 hours [ DST ]


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
© Copyright 2014, Red Hat Inc. All rights reserved. JBoss and Hibernate are registered trademarks and servicemarks of Red Hat, Inc.