Hi,

I have created a helper that is setup to close the session at HttpContext.EndRequest but in some of the other documentation I have seen, the session gets closed right after the save/update/delete has occured.

For example, a delete method on my helper looks like this:



I don't have a finally block to close the session because this is hooked up to happen at HttpContext.EndRequest. Is this OK or should I really be closing the session in a finally block? If I do close it in a finally block, does this mean that I will not be able to access properties on a saved or updated object without re-querying?

Thanks,

Jason

in my opinion, you are fine leaving the session.Close() in the Context_EndRequest method AS LONG AS you abandon all work when you do receive an error from your transactions. So for example, in an asp page you might have:


if you get the error on the tran, you have to stop what you're doing and basically abandon all changes and present a message to the user. this way, you can leverage the Context_EndRequest to close the session.

-devon

OK...thanks. I did get experience a couple of strange exceptions a while back (possible nonthreadsafe access to session) but I realised that I wasn't throwing the exception again from my helper and so was attempting to continue to use the session. Once I fixed that, all seemed to be fine.

Thanks,

Jason