I am writing a BaseDAO for a c#.net application that uses nHibernate. I am having trouble making use of session.get in a generic manner, so that it can be utilized by my other DAOs.

I currently have something like this:


protected Task get(int id)
{
ISessionFactory factory = cfg.BuildSessionFactory();

ISession session = factory.OpenSession();

return session.Get(typeof(Task), 1) as Task;

}


I want to change this so that it will operate on any of my Persistant objects, i.e not just Task, i want to do something like pass in the Persistant class into the method and then this gets used in the 'get' method.

But im a little unsure how to do this, any suggestions?

I have managed to get it working like this:

Base Class:

protected Object get(Object ob,int id)
{
ISessionFactory factory = cfg.BuildSessionFactory();
ISession session = factory.OpenSession();
return session.Get(ob.GetType(),id);
}


The extending class:

public Tasks getTask(int id)
{
Tasks t = new Tasks();
return (Tasks)base.get(t,id);
}


But this seem like abit of a hack...can it be cleaned up in anyway?

It can't be cleaned up unless you use generics.
And by the way, don't create a new session factory for each call of Get, it's incorrect and very expensive. Read the documentation.

Oh thanks for the tip