-->
These old forums are deprecated now and set to read-only. We are waiting for you on our new forums!
More modern, Discourse-based and with GitHub/Google/Twitter authentication built-in.

All times are UTC - 5 hours [ DST ]



Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 
Author Message
 Post subject: Namespace naming
PostPosted: Mon May 16, 2005 3:56 am 
Newbie

Joined: Mon May 16, 2005 3:45 am
Posts: 3
I love NHibernate and I have one suggestion: Why dont use full meaning names for namespace? For example: NHibernate.Configuration instead of NHibernate.Cfg ??

(I know there is a Configuration class, but we can refactor it if we want ;))


Top
 Profile  
 
 Post subject:
PostPosted: Mon May 16, 2005 8:32 am 
Contributor
Contributor

Joined: Wed May 11, 2005 4:59 pm
Posts: 1766
Location: Prague, Czech Republic
What name do you suggest for the Configuration class? If we rename Cfg to Configuration, people will have to write Configuration.Configuration everywhere and it's ugly.


Top
 Profile  
 
 Post subject:
PostPosted: Thu May 19, 2005 10:00 pm 
Newbie

Joined: Mon May 16, 2005 3:45 am
Posts: 3
I suggest one solution:

Cfg namespace -> Configuration namespae

Configuration class -> ConfigurationManager class


Top
 Profile  
 
 Post subject:
PostPosted: Fri May 20, 2005 12:00 pm 
Contributor
Contributor

Joined: Thu May 12, 2005 9:45 am
Posts: 593
Location: nhibernate.org
The Configuration class is not a "manager"; it is some kind of "container"...
So we can go for ConfigurationHolder or ConfigurationContainer.

_________________
Pierre Henri Kuaté.
Get NHibernate in Action Now!


Top
 Profile  
 
 Post subject:
PostPosted: Fri May 20, 2005 12:32 pm 
Regular
Regular

Joined: Mon May 16, 2005 2:15 pm
Posts: 59
Bah... you guys want to make breaking changes just for no real reason. I think Cfg is ubiquitious enough to remain as is and the Configuration class is named very well.

I know you weren't asking for votes, but there's mine.

PilotBob


Top
 Profile  
 
 Post subject:
PostPosted: Sat May 21, 2005 5:51 am 
Newbie

Joined: Mon May 16, 2005 3:45 am
Posts: 3
Pilotbob wrote:
Bah... you guys want to make breaking changes just for no real reason. I think Cfg is ubiquitious enough to remain as is and the Configuration class is named very well.

I know you weren't asking for votes, but there's mine.

PilotBob


NHibernate is still in beta stage, so we can accept the breaking changes after refactoring.

Actually, I can have a customized version of NHibernate, with my own full meaning namespace names. But I hope NHibernate will be the greatest O/R Mapping framework for .NET. A nice framework is a powerful, an easy to use, but also need to be an easy to understand one.


Top
 Profile  
 
 Post subject:
PostPosted: Sat May 21, 2005 7:08 am 
Contributor
Contributor

Joined: Wed May 11, 2005 4:59 pm
Posts: 1766
Location: Prague, Czech Republic
I agree with PilotBob here and I'm very skeptical about that change. I think Cfg will do no harm, it is an abbreviation, but an immediately obvious one. And adding meaningless suffixes like Manager, Holder, or something, to Configuration class just so that we can spell one namespace in full seems pointless to me, given that you usually write a namespace only once at the top of the file in "using" declaration.

If one of the other developers wants to take the responsibility and make the change, I won't be against it, but I won't do it myself.


Top
 Profile  
 
 Post subject:
PostPosted: Sat May 21, 2005 8:12 am 
Contributor
Contributor

Joined: Thu May 12, 2005 9:45 am
Posts: 593
Location: nhibernate.org
Agree :!:

(if someone decide to do it, can he change "hibernate.cfg.xml" to "nhibernate.cfg.xml" and replace extension "hbm.xml" by "nhm.xml" :wink: )

_________________
Pierre Henri Kuaté.
Get NHibernate in Action Now!


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 

All times are UTC - 5 hours [ DST ]


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
© Copyright 2014, Red Hat Inc. All rights reserved. JBoss and Hibernate are registered trademarks and servicemarks of Red Hat, Inc.