NullReferenceException from GenericPersistentBag

Nels_P_Olsen · **Posted:** Wed Jan 27, 2010 6:00 pm

We're trying to upgrade from NH 2.0.1 to NH 2.1.2. When we access an uninitialized collection mapped as a bag, we get a NullReferenceException from GenericPersistentBag.GetEnumerator().

Looking at the code, if the constructor just taking a session is called, it never initializes the private field gbag. It looks like almost all the other classes in NHibernate\Collection and NHibernate\Collection\Generic have this kind of problem.

I worked around it by modifying the constructor from

Code:

public PersistentGenericBag(ISessionImplementor session) : base(session) {}

to

Code:

public PersistentGenericBag(ISessionImplementor session) : this(session, new List<T>()) {}

GenericPersistentBag.cs (and probably the other collection classes) have changed since NH 2.0.1, but the older code still has similar problems. Apparently something changed in NH so that these constructors are now getting called when they weren't before?

Hasn't anyone else seen this problem? My confidence in NH is dropping after seeing these glaring bugs in the code ...

wolli · **Posted:** Thu Jan 28, 2010 2:52 am

You better post that at http://groups.google.com/group/nhusers/topics?hl=en or open an JIRA issue. Noone of the developers is listening here anymore. I recently tested upgrading from 1.2 to 2.1.2GA and didn't ran into that problem, but we don't use lazy loading at all and the tests were at best superficial.