Hibernate 3.2.4SP1

Hello,

it seems for me, that touching any (lazy!) m:n collection inside an event-listener results in an AssertionFailure on PostFlush:


Have created TestCase for demonstration: Two Entities with (lazy) m:n relationship between eachother, and a PostUpdateListener examining the (changed) collections of the relationship after update. See http://opensource.atlassian.com/projects/hibernate/browse/HHH-2763

Can somebody clarifiy that this is a bug ?

The problem is that AbstractFlushingEventListener.performExecutions() can result in new CollectionEntrys being created (because listeners access lazy collections, etc...). These CollectionEntry objects are technically created during a flush but not when the PersistenceConext.flushing attribute is set.

I looks safe to update AbstractFlushingEventListener.performExecutions() to:

session.getPersistenceContext().setFlushing(true);
try {
session.getJDBCContext().getConnectionManager().flushBeginning();
// we need to lock the collection caches before
// executing entity inserts/updates in order to
// account for bidi associations
session.getActionQueue().prepareActions();
session.getActionQueue().executeActions();
}
catch (HibernateException he) {
log.error("Could not synchronize database state with session", he);
throw he;
}
finally {
session.getPersistenceContext().setFlushing(false);
session.getJDBCContext().getConnectionManager().flushEnding();
}

That should get rid of this issue, but I am have not analyzed everything that occurs in session.getActionQueue().executeActions() so there could be some side affect, but since the 'flushing' attribute is really only used for CollectionEntry objects, it seems safe.