Hibernate version: 3.1.3

I noticed that if I save(foo) its version number is incremented even if it has never been changed (its setters have never even been invoked). This causes concurrency problems because I get StaleObjectStateException even if no data is actually stale.

I have cascade="save-update" set which is triggering save(foo) so I don't really control this. I expect foo to be saved to the DB if it does not already exist there, update in the DB if it has been changed, and nothing to happen if it is not dirty and already exists in the DB.

Any ideas?

I believe this is a bug.

If PersistentSet.add() is invoked on an element which is already in the Set and the Set is initialized then isOperationQueueEnabled() will return false, exists will be set to null and then the code will mark the Set as dirty even though it already contains the element. I believe a quick fix would be to modify the first line of code from:

if (exists==null) {
write();
return set.add(value);
}

to:

if (exists==null) {
boolean result = set.add(value);
if (result) {
write();
}
return result;
}

I have tested this locally and it fixes the problem for me. I posted http://opensource.atlassian.com/project ... e/HHH-1668 to this effect.

Have you tried select-before-update in your mapping?

No, I did not try select-before-update. The benefit of the above fix is that it fixes the problem *without* the negative performance impact associated with select-before-update.

Thanks for the idea though!