easy question about closing sesssions

grimholtz · **Joined:** Fri Nov 05, 2004 2:13 pm **Posts:** 7

Hi,
I'm a Hibernate noobie. Typical Hibernate code I've seen so far might look like this:

Code:

public void save(MyBean myBean) throws Exception {
  Session session = sessionFactory.openSession();
  Transaction tx = session.beginTransaction();   
  session.save(myBean);
  tx.commit();
  session.close();
}

No one seems to use try/finally blocks to close the session if the save() call fails. Isn't this necessary??

Code:

public void save(MyBean myBean) throws Exception {
  Session session = null;
  Transaction tx = null;
  try {
    session = sessionFactory.openSession();
    tx = session.beginTransaction();   
    session.save(myBean);
    tx.commit();
  }
  finally {
    if (session != null)
      session.close();
  }
}

Thanks in advance for any advice,
Eric

Myk · **Joined:** Sun Jan 04, 2004 2:46 pm **Posts:** 147

You are correct, personally I always do

Code:

try
{
    // hibernate logic

    // commit here
}
catch ( HibernateException e )
{
    // rollback here
}
finally
{
    // close session here
}

I think most people use the simplified version to avoid typing out all the exception logic in examples.

emmanuel · **Posted:** Sat Nov 06, 2004 7:26 am

It is very necessary.
Myk pseudo code is better. It rollback the Tx if womething goes wrong.

grimholtz · **Joined:** Fri Nov 05, 2004 2:13 pm **Posts:** 7

thank you!