Query.iterate() and ResultSet/Statement closure...

r.simoni · **Joined:** Wed May 05, 2010 8:39 am **Posts:** 7

I'm not sure, but using method Query.iterate() I think related ResultSet and Statement are
not closed if you don't traverse the Iterator till the end.

I would like to avoid problems in this type of scenario:

I have a CustomerPersistenceAdapter with a getWonderfulCustomers returning
and Iterator<Customer>.
Another developer needs only the first wonderful Customer and looking
at an already developed api he writes:

Code:

    ...
    Iterator<Customer> it = persistenceAdapter.getWonderfulCustomers();
    return (it.hasNext()) ? it.next() : null;
    ...

If the Iterator<Customer> returned by getWonderfulCustomers need to traverse
more than one Customer, are the ResultSet and Statement closed?
Can this create problems or there are other subsystems to clean or notify this
situation?

Thanks in advance
Bye

iometrine · **Joined:** Fri Aug 24, 2007 9:47 am **Posts:** 21

Isn't there a size method on PersistenceAdapter who you will let to check ?

r.simoni · **Joined:** Wed May 05, 2010 8:39 am **Posts:** 7

Hi iometrine and thanks. I could add a size method, but this isn't the purpose of my question.

I'm wondering whether I have to recommend CustomerPersistenceAdapter users to traverse returned Iterator<Customer> till the end (adding method documentation for example).

I would like to avoid memory leaks for ResultSet/Statement leaved in memory.

Probably only an Hibernate developer can answer this question...

r.simoni · **Joined:** Wed May 05, 2010 8:39 am **Posts:** 7

Hi, any answer?

r.simoni · **Joined:** Wed May 05, 2010 8:39 am **Posts:** 7

Found an answer, tell me if it's good...

It's better to use .scroll() method and return a ScrollableResults.
I have seen that this class has a close method with api doc saying "Release resources immediately".

What do you think?

r.simoni · **Joined:** Wed May 05, 2010 8:39 am **Posts:** 7

No answers means "ops there is a problem?"