Hello,

I'm trying to code a Dao class and its integration testing but I run into several issues.

Here is the Dao class:



And here is the integration testing:



The first issue is that, after the test is run, there is no record in the database with a name A_UNIQUE_NEW_NAME but there is one with the name A_UNIQUE_NAME. This means that the object was not updated.

The statement
preference.setName("A_UNIQUE_NEW_NAME");
preferenceDao.update(preference);
did not do its job.

I also tried to delete the record from the database by adding the statement
preferenceDao.delete(preference);
to the integration testing.

Here is how it looks with the added statement:



But it did not delete the record from the database.

The record was still in the table with its original name.

So I tried to add another delete statement, a bit shooting in the dark, to have the test like:



But it did not help. The record was still in the database.

Note that I'm running the test against a MySQL database.

Normally I have my integration testing running against an in memory HSQLDB database, but in this case I'm running it against a MySQL database to see how the test behaves.

Now, I'm trying to retrieve the record from the table.

Remember that the record could not be deleted by the delete statements, and it thus still exists in the table.

So, I add to the integration test a selectById statement.

The test now looks like:

@Test
public void testSave() {
Preference preference = new Preference();
preference.setName("A_UNIQUE_NAME");
preference.setValue("VALUE");
Integer preferenceId = preferenceDao.insert(preference);
assertNotNull(preferenceId);
preference.setName("A_UNIQUE_NEW_NAME");
preferenceDao.update(preference);
Preference loadedPreference = preferenceDao.selectById(preferenceId);
assertNotNull(loadedPreference.getId());
assertEquals(preference.getName(), loadedPreference.getName());
preferenceDao.delete(preference);
loadedPreference = preferenceDao.selectById(preferenceId);
}

But when running the test I got a
org.hibernate.ObjectNotFoundException: No row with the given identifier exists

Here is the stack:

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.043 sec <<< FAILURE!
testSave(com.thalasoft.learnintouch.core.dao.PreferenceDaoTest) Time elapsed: 0.038 sec <<< ERROR!
org.springframework.orm.hibernate3.HibernateObjectRetrievalFailureException: No row with the given identifier exists: [com.thalasoft.learnintouch.core.domain.Preference#114]; nested exception is org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [com.thalasoft.learnintouch.core.domain.Preference#114]
at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:660)
at org.springframework.orm.hibernate3.HibernateAccessor.convertHibernateAccessException(HibernateAccessor.java:412)
at org.springframework.orm.hibernate3.HibernateTemplate.doExecute(HibernateTemplate.java:424)
at org.springframework.orm.hibernate3.HibernateTemplate.executeWithNativeSession(HibernateTemplate.java:374)
at org.springframework.orm.hibernate3.HibernateTemplate.load(HibernateTemplate.java:563)
at org.springframework.orm.hibernate3.HibernateTemplate.load(HibernateTemplate.java:557)
at com.thalasoft.learnintouch.core.dao.hibernate.PreferenceHibernateDao.selectById(PreferenceHibernateDao.java:40)


So I tried to catch the exception in the Dao class, by adding a catch block like:



But when running the test, I still got a org.hibernate.ObjectNotFoundException: No row with the given identifier exists.

Here is the stack:

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.052 sec <<< FAILURE!
testSave(com.thalasoft.learnintouch.core.dao.PreferenceDaoTest) Time elapsed: 0.047 sec <<< ERROR!
org.springframework.orm.hibernate3.HibernateObjectRetrievalFailureException: No row with the given identifier exists: [com.thalasoft.learnintouch.core.domain.Preference#113]; nested exception is org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [com.toto.core.domain.Preference#113]
at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:660)
at org.springframework.orm.hibernate3.HibernateAccessor.convertHibernateAccessException(HibernateAccessor.java:412)
at org.springframework.orm.hibernate3.HibernateTemplate.doExecute(HibernateTemplate.java:424)
at org.springframework.orm.hibernate3.HibernateTemplate.executeWithNativeSession(HibernateTemplate.java:374)
at org.springframework.orm.hibernate3.HibernateTemplate.load(HibernateTemplate.java:563)
at org.springframework.orm.hibernate3.HibernateTemplate.load(HibernateTemplate.java:557)
at com.toto.core.dao.hibernate.PreferenceHibernateDao.selectById(PreferenceHibernateDao.java:40)

It's like the catch block did not catch the exception.

For info, here is the mapping:

Or, do I need to have a flush() in each of the persisting methods of the Dao class ?

Like in the following:

Adding the statement

getHibernateTemplate().flush();

seems to have solved some issues here.

The only issue remaining here the one with the exception.

Here it is again:

No row with the given identifier exists: [com.thalasoft.learnintouch.core.domain.Preference#141]
at org.hibernate.impl.SessionFactoryImpl$1.handleEntityNotFound(SessionFactoryImpl.java:386)
at org.hibernate.proxy.AbstractLazyInitializer.checkTargetState(AbstractLazyInitializer.java:130)
at org.hibernate.proxy.AbstractLazyInitializer.initialize(AbstractLazyInitializer.java:119)
at org.hibernate.proxy.AbstractLazyInitializer.getImplementation(AbstractLazyInitializer.java:150)
at org.hibernate.proxy.pojo.cglib.CGLIBLazyInitializer.invoke(CGLIBLazyInitializer.java:150)
at com.thalasoft.learnintouch.core.domain.Preference$$EnhancerByCGLIB$$e56184b0.toString(<generated>)
at java.lang.String.valueOf(String.java:2827)
at junit.framework.Assert.assertNull(Assert.java:225)
at com.thalasoft.learnintouch.core.dao.PreferenceDaoTest.testSave(PreferenceDaoTest.java:29)

The last exception was simply caused by the call

assertNull(loadedPreference);

After reading all the blogs I could google, I understand I should not do a flush in the Dao methods like

getHibernateTemplate().flush();

So I remove that statement and my methods now look like:



But then, when running my integration test against the MySql database, I have some data left in the table after the test run is over.

Namely, I end up with an inserted, and not removed, record:

mysql> select * from preference where name like '%_UNIQUE_NAME';
+-----+---------+---------------+------------+-------+
| id | version | name | is_ml_text | value |
+-----+---------+---------------+------------+-------+
| 167 | 0 | A_UNIQUE_NAME | NULL | VALUE |
+-----+---------+---------------+------------+-------+

And this was not happening with the flush statements in place.

I thought Spring would provide me with some rolled back transaction feature so as to isolate my integration tests.

Where are the Hibernate gurus...

I have now implemented a GenericDao that serves as a base class to the application Dao's but I still have the flush() calls...
Maybe my integration tests are not testing in a sensible way...

I just ordered POJO in Action. It should help. Hopefully.